Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: positivity extension for the Gamma function #7888

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: positivity extension for the Gamma function #7888

wants to merge 2 commits into from

Conversation

hrmacbeth
Copy link
Member

Open in Gitpod

@hrmacbeth hrmacbeth added t-meta Tactics, attributes or user commands awaiting-review The author would like community review of the PR awaiting-CI labels Oct 24, 2023
@alexjbest
Copy link
Member

Ideally there would be a test or some more use of Qq to make sure it doesn't break if someone changes one of the Gamma_pos or Gamma_nonneg lemmas, but I think if it does break we'd find out sooner or later anyway, so I'm fine with this as is.

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by alexjbest.

@robertylewis
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 24, 2023
bors bot pushed a commit that referenced this pull request Oct 24, 2023
@hrmacbeth
chore: positivity extension for the Gamma function (#7888)
bf077b1
@bors
Copy link

bors bot commented Oct 24, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: positivity extension for the Gamma function [Merged by Bors] - chore: positivity extension for the Gamma function Oct 24, 2023
@bors bors bot closed this Oct 24, 2023
@bors bors bot deleted the HM-Gamma-positivity branch October 24, 2023 17:43
@dwrensha dwrensha mentioned this pull request Oct 24, 2023
Closed
@dwrensha
Copy link
Member

Ideally there would be a test or some more use of Qq to make sure it doesn't break if someone changes one of the Gamma_pos

Added in #7900.

bors bot pushed a commit that referenced this pull request Oct 26, 2023
@dwrensha
chore: use Qq in new Gamma positivity extension (#7900)
2392a12 
Adds Qq static checking, as requested in this comment: #7888 (comment)

The `have pa' : Q(..) := pa` lines are necessary to sort out typeclass instances of `LE` and `LT`.
grunweg pushed a commit that referenced this pull request Nov 1, 2023
@dwrensha @grunweg
chore: use Qq in new Gamma positivity extension (#7900)
1038cbc 
Adds Qq static checking, as requested in this comment: #7888 (comment)

The `have pa' : Q(..) := pa` lines are necessary to sort out typeclass instances of `LE` and `LT`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hrmacbeth @alexjbest @robertylewis @dwrensha