[Merged by Bors] - chore: use Qq in new Gamma positivity extension #7900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwrensha
added
awaiting-review
dwrensha
changed the title
alexjbest
reviewed
Oct 26, 2023
| let pa' ← mkAppM ``Gamma_nonneg_of_nonneg #[pa] | ||
| pure (.nonnegative pa') | ||
| have pa' : Q(0 ≤ $a) := pa | ||
| pure (.nonnegative (q(Gamma_nonneg_of_nonneg $pa') : Q(0 ≤ $e))) |
There was a problem hiding this comment.
You should be able to do
| .positive (pa : Q(0 < $a)) =>
pure (.positive (q(Gamma_pos_of_pos $pa) : Q(0 < $e)))
| .nonnegative (pa : Q(0 ≤ $a)) =>
pure (.nonnegative (q(Gamma_nonneg_of_nonneg $pa) : Q(0 ≤ $e)))
|
This makes me think we need some sort of |
alexjbest
added
awaiting-author
dwrensha
added
awaiting-review
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by alexjbest. |
leanprover-community-mathlib4-bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
Adds Qq static checking, as requested in this comment: #7888 (comment) The `have pa' : Q(..) := pa` lines are necessary to sort out typeclass instances of `LE` and `LT`.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
grunweg
pushed a commit
that referenced
this pull request
Nov 1, 2023
Adds Qq static checking, as requested in this comment: #7888 (comment) The `have pa' : Q(..) := pa` lines are necessary to sort out typeclass instances of `LE` and `LT`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Qq static checking, as requested in this comment: #7888 (comment)
The
have pa' : Q(..) := palines are necessary to sort out typeclass instances ofLEandLT.