Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - doc: convert comments to docstrings and doc-comments #7951

Closed
wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member


Open in Gitpod

@eric-wieser eric-wieser added the documentation Improvements or additions to documentation label Oct 26, 2023
@@ -118,7 +121,8 @@ theorem nat_cast_apply [NatCast β] (n : ℕ) (x : α) : (n : C(α, β)) x = n :
rfl
#align continuous_map.nat_cast_apply ContinuousMap.nat_cast_apply

-- ### "int_cast"
/-! ### "int_cast"-/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix (lean4ify) the names of these headers at least if we are going to make them appear in the docs, and put them in backticks

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

@j-loreaux
Copy link
Collaborator

after addressing Alex's comment, this is ready.

bors d+

@bors
Copy link

bors bot commented Oct 30, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 30, 2023
@bors
Copy link

bors bot commented Oct 30, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title doc: convert comments to docstrings and doc-comments [Merged by Bors] - doc: convert comments to docstrings and doc-comments Oct 30, 2023
@bors bors bot closed this Oct 30, 2023
@bors bors bot deleted the eric-wieser/docstrings branch October 30, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated documentation Improvements or additions to documentation ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants