-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: generalized eigenspaces are independent #8177
Conversation
This is the not the definition I was expecting for |
Great point, I should have thought of this myself! I'm already yak shaving to some extent so I'm not sure if I have the appetite to develop the full theory at the moment. A reasonable compromise might be keep these results without taking ownership of the Given your remarks, I'll split this PR in two: I think the results about independence should be less controversial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty nice! Minor comments.
I pushed a small golf. Feel free to revert if you prefer. Merge once CI passes. bors d+ |
✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
The main change is to upgrade the existing `Module.End.eigenspaces_independent`, which applied only to eigenspaces (and required a `[Field K]` assumption) to `Module.End.independent_generalizedEigenspace`, which applies to generalized eigenspaces (and requires only `[NoZeroSMulDivisors R M]`) Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Pull request successfully merged into master. Build succeeded: |
The main change is to upgrade the existing `Module.End.eigenspaces_independent`, which applied only to eigenspaces (and required a `[Field K]` assumption) to `Module.End.independent_generalizedEigenspace`, which applies to generalized eigenspaces (and requires only `[NoZeroSMulDivisors R M]`) Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
The main change is to upgrade the existing
Module.End.eigenspaces_independent
, which applied only to eigenspaces (and required a[Field K]
assumption) toModule.End.independent_generalizedEigenspace
, which applies to generalized eigenspaces (and requires only[NoZeroSMulDivisors R M]
)Split out from #7963