Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: generalized eigenspaces are independent #8177

Closed
wants to merge 4 commits into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Nov 4, 2023

The main change is to upgrade the existing Module.End.eigenspaces_independent, which applied only to eigenspaces (and required a [Field K] assumption) to Module.End.independent_generalizedEigenspace, which applies to generalized eigenspaces (and requires only [NoZeroSMulDivisors R M])


Split out from #7963

Open in Gitpod

@ocfnash ocfnash added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Nov 4, 2023
@j-loreaux
Copy link
Collaborator

This is the not the definition I was expecting for IsTriangularizable. Instead, I was expecting: "there exists a maximal chain of invariant subspaces". Over a finite dimensional vector space over a field, the definitions coincide, but not in the infinite dimensional setting. Thoughts?

@ocfnash
Copy link
Contributor Author

ocfnash commented Nov 5, 2023

This is the not the definition I was expecting for IsTriangularizable. Instead, I was expecting: "there exists a maximal chain of invariant subspaces". Over a finite dimensional vector space over a field, the definitions coincide, but not in the infinite dimensional setting. Thoughts?

Great point, I should have thought of this myself! I'm already yak shaving to some extent so I'm not sure if I have the appetite to develop the full theory at the moment. A reasonable compromise might be keep these results without taking ownership of the IsTriangularizable name.

Given your remarks, I'll split this PR in two: I think the results about independence should be less controversial.

Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty nice! Minor comments.

Mathlib/LinearAlgebra/Eigenspace/Basic.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Eigenspace/Basic.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Eigenspace/Basic.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/Eigenspace/Basic.lean Outdated Show resolved Hide resolved
@ocfnash ocfnash changed the title feat: expand API on generalized eigenspaces of linear endomorphisms feat: generalized eigenspaces are independent Nov 8, 2023
@j-loreaux
Copy link
Collaborator

I pushed a small golf. Feel free to revert if you prefer. Merge once CI passes.

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Nov 8, 2023

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Nov 8, 2023
@ocfnash
Copy link
Contributor Author

ocfnash commented Nov 8, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 8, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 8, 2023
The main change is to upgrade the existing `Module.End.eigenspaces_independent`, which applied only to eigenspaces (and required a `[Field K]` assumption) to `Module.End.independent_generalizedEigenspace`, which applies to generalized eigenspaces (and requires only `[NoZeroSMulDivisors R M]`)



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 8, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: generalized eigenspaces are independent [Merged by Bors] - feat: generalized eigenspaces are independent Nov 8, 2023
@mathlib-bors mathlib-bors bot closed this Nov 8, 2023
@mathlib-bors mathlib-bors bot deleted the ocfnash/eigen branch November 8, 2023 19:50
grunweg pushed a commit that referenced this pull request Dec 15, 2023
The main change is to upgrade the existing `Module.End.eigenspaces_independent`, which applied only to eigenspaces (and required a `[Field K]` assumption) to `Module.End.independent_generalizedEigenspace`, which applies to generalized eigenspaces (and requires only `[NoZeroSMulDivisors R M]`)



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants