Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: in finite dimensions, if a linear endomorphism is triangularizable, so is its restriction to any invariant submodule #8212

Closed
wants to merge 9 commits into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Nov 5, 2023

@ocfnash ocfnash added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Nov 5, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib label Nov 5, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib label Nov 8, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 8, 2023
@ocfnash ocfnash removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 8, 2023
@ocfnash
Copy link
Contributor Author

ocfnash commented Nov 9, 2023

I note the following request to reviewers from @semorrison on Zulip:

if you see a PR that is renaming a file, but git does not report it as a rename (because too much stuff
was changed at the same time), can we please ask the author to make separate PRs doing the rename
and making the changes?

Renames that are not detected as renames are very likely to break nightly-testing. (Thanks to Matthew
Ballard for salvaging one such breakage overnight.)

Thus if the proposed rename in this PR is accepted, we should not merge this PR directly but split out
a rename-only PR first. I will wait for review before I make such a split.

@jcommelin
Copy link
Member

I would like to see the renaming PR (-;

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 10, 2023
@ocfnash
Copy link
Contributor Author

ocfnash commented Nov 10, 2023

I would like to see the renaming PR (-;

Created here #8318

Yikes: git's auto conflict resolver just discarded all my changes!
@ocfnash ocfnash added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 10, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Nov 13, 2023

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the awaiting-review The author would like community review of the PR label Nov 13, 2023
@ocfnash
Copy link
Contributor Author

ocfnash commented Nov 13, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 13, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 13, 2023
…ble, so is its restriction to any invariant submodule (#8212)
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 13, 2023

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Nov 13, 2023
…ble, so is its restriction to any invariant submodule (#8212)
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 13, 2023

Build failed (retrying...):

  • Build

mathlib-bors bot pushed a commit that referenced this pull request Nov 13, 2023
…ble, so is its restriction to any invariant submodule (#8212)
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 13, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: in finite dimensions, if a linear endomorphism is triangularizable, so is its restriction to any invariant submodule [Merged by Bors] - feat: in finite dimensions, if a linear endomorphism is triangularizable, so is its restriction to any invariant submodule Nov 13, 2023
@mathlib-bors mathlib-bors bot closed this Nov 13, 2023
@mathlib-bors mathlib-bors bot deleted the ocfnash/eigen_triang branch November 13, 2023 11:57
alexkeizer pushed a commit that referenced this pull request Nov 17, 2023
…ble, so is its restriction to any invariant submodule (#8212)
alexkeizer pushed a commit that referenced this pull request Nov 21, 2023
…ble, so is its restriction to any invariant submodule (#8212)
grunweg pushed a commit that referenced this pull request Dec 15, 2023
…ble, so is its restriction to any invariant submodule (#8212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants