Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment: remove #align and benchmark #8214

Closed
wants to merge 11 commits into from
Closed

experiment: remove #align and benchmark #8214

wants to merge 11 commits into from

Conversation

semorrison
Copy link
Contributor

Not a proposal to actually do this, rather for comparison with the benchmarking results at #8199


Open in Gitpod

@semorrison
Copy link
Contributor Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit e6f9872.
The entire run failed.
Found no significant differences.

@semorrison
Copy link
Contributor Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 2ac7d87.
The entire run failed.
Found no significant differences.

@semorrison
Copy link
Contributor Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit d4010c7.
The entire run failed.
Found no significant differences.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 5, 2023
@semorrison
Copy link
Contributor Author

!bench

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 5, 2023
@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 884adf5.
The entire run failed.
Found no significant differences.

@semorrison
Copy link
Contributor Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 9411012.
The entire run failed.
Found no significant differences.

@semorrison
Copy link
Contributor Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 58b94ba.
There were significant changes against commit ce4b7e4:

  Benchmark      Metric           Change
  ======================================
+ build          interpretation   -18.1%
+ open Mathlib   instructions     -24.2%
+ open Mathlib   wall-clock       -13.8%
+ size           .lean            -10.1%

@semorrison semorrison closed this Nov 6, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 8, 2023
We'll need to do this step anyway when it is time to remove them all.

(See #8214 where I'm benchmarking the removal.)



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
mathlib-bors bot pushed a commit that referenced this pull request Nov 8, 2023
We'll need to do this step anyway when it is time to remove them all.

(See #8214 where I'm benchmarking the removal.)



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
grunweg pushed a commit that referenced this pull request Dec 15, 2023
We'll need to do this step anyway when it is time to remove them all.

(See #8214 where I'm benchmarking the removal.)



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants