[Merged by Bors] - chore(AlgebraicGeometry.Morphisms.RingHomProperties): speedups #8299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collares
added
the
awaiting-review
|
!bench |
|
Here are the benchmark results for commit 604fc77. Benchmark Metric Change
==================================================================================
+ build maxrss -19.6%
+ build tactic execution -5.3%
+ ~Mathlib.AlgebraicGeometry.Morphisms.RingHomProperties instructions -64.6% |
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 12, 2023
I don't really understand this file, but I was bothered by the sole declaration requiring more than a million heartbeats. I noticed strategically adding a few `conv`s can make `sourceAffineLocally_of_source_open_cover_aux` not require a bump.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
alreadydone
reviewed
Nov 12, 2023
Comment on lines
-268
to
270
| set_option maxHeartbeats 4000000 in | ||
| theorem sourceAffineLocally_of_source_open_cover_aux (h₁ : RingHom.RespectsIso @P) | ||
| (h₃ : RingHom.OfLocalizationSpanTarget @P) {X Y : Scheme} (f : X ⟶ Y) (U : X.affineOpens) | ||
| (s : Set (X.presheaf.obj (op U.1))) (hs : Ideal.span s = ⊤) |
There was a problem hiding this comment.
Ah, I wish I knew that beforehand :( I'd be happy to have my hacky proof replaced by a proper one, of course.
alexkeizer
pushed a commit
that referenced
this pull request
Nov 17, 2023
I don't really understand this file, but I was bothered by the sole declaration requiring more than a million heartbeats. I noticed strategically adding a few `conv`s can make `sourceAffineLocally_of_source_open_cover_aux` not require a bump.
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
I don't really understand this file, but I was bothered by the sole declaration requiring more than a million heartbeats. I noticed strategically adding a few `conv`s can make `sourceAffineLocally_of_source_open_cover_aux` not require a bump.
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
I don't really understand this file, but I was bothered by the sole declaration requiring more than a million heartbeats. I noticed strategically adding a few `conv`s can make `sourceAffineLocally_of_source_open_cover_aux` not require a bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really understand this file, but I was bothered by the sole declaration requiring more than a million heartbeats. I noticed strategically adding a few
convs can makesourceAffineLocally_of_source_open_cover_auxnot require a bump.