[Merged by Bors] - perf(AlgebraicGeometry): Fix slow and bad proofs #7747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leanprover-community-mathlib4-bot
added
merge-conflict
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause |
erdOne
added
awaiting-review
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
@erdOne This seems like an improvement! Would you mind fixing the build please? |
leanprover-community-mathlib4-bot
added
the
merge-conflict
|
@erdOne Feel free to revert my hacky 42a9855 as part of this (much better) PR, or ping me if you want me to do the revert instead. I didn't know of this PR before. Edit: I ended up just reverting it myself to save you the trouble, hopefully that's not a problem. Feel free to force push your local copy if it conflicts with any changes you might have. |
leanprover-community-mathlib4-bot
removed
the
merge-conflict
@jcommelin The build failure was just a "no space left on device error". I triggered a rebuild and it was green. |
|
@collares Thanks for the fix! |
|
!bench |
|
Here are the benchmark results for commit 55c54de. Benchmark Metric Change
==============================================================================
+ ~Mathlib.AlgebraicGeometry.AffineScheme instructions -84.4%
- ~Mathlib.AlgebraicGeometry.GammaSpecAdjunction instructions 8.5%
+ ~Mathlib.AlgebraicGeometry.Morphisms.QuasiSeparated instructions -75.3%
+ ~Mathlib.AlgebraicGeometry.Morphisms.RingHomProperties instructions -24.2%
- ~Mathlib.AlgebraicGeometry.Restrict instructions 5.1%
- ~Mathlib.Topology.Sheaves.SheafCondition.UniqueGluing instructions 51.0%(Note: the three files becoming slower is due to new lemmas added to those files. - Junyan) |
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 12, 2023
Fixed `AlgebraicGeometry/AffineSchemes.lean`, `AlgebraicGeometry/Morphisms/QuasiSeparated.lean` and `AlgebraicGeometry/Morphisms/RingHomProperties.lean`. Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Mauricio Collares <mauricio@collares.org>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
alexkeizer
pushed a commit
that referenced
this pull request
Nov 17, 2023
Fixed `AlgebraicGeometry/AffineSchemes.lean`, `AlgebraicGeometry/Morphisms/QuasiSeparated.lean` and `AlgebraicGeometry/Morphisms/RingHomProperties.lean`. Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Mauricio Collares <mauricio@collares.org>
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
Fixed `AlgebraicGeometry/AffineSchemes.lean`, `AlgebraicGeometry/Morphisms/QuasiSeparated.lean` and `AlgebraicGeometry/Morphisms/RingHomProperties.lean`. Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Mauricio Collares <mauricio@collares.org>
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
Fixed `AlgebraicGeometry/AffineSchemes.lean`, `AlgebraicGeometry/Morphisms/QuasiSeparated.lean` and `AlgebraicGeometry/Morphisms/RingHomProperties.lean`. Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Mauricio Collares <mauricio@collares.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
AlgebraicGeometry/AffineSchemes.lean,AlgebraicGeometry/Morphisms/QuasiSeparated.leanandAlgebraicGeometry/Morphisms/RingHomProperties.lean.