Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: rename LinearAlgebra.Eigenspace.IsAlgClosed to LinearAlgebra.Eigenspace.Triangularizable #8318

Closed
wants to merge 2 commits into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Nov 10, 2023

The motivation is that I wish to add further results about triangularizability of linear endomorphisms and I claim this file is a natural home.

This rename-only PR exists to prevent breaking 'nightly-testing'.


Open in Gitpod

…a.Eigenspace.Triangularizable`

The motivation is that I wish to add further results about triangularizability of linear
endomorphisms and I claim this file is a natural home.

This rename-only PR exists to prevent breaking 'nightly-testing'.
@eric-wieser
Copy link
Member

I think it would be worth picking up the start (or even all of) the docstring at the same time:

/-!
# Triangularizable linear endomorphisms

This file contains basic results relevant to the triangularizability of linear endomorphisms.

3 lines of diff isn't going to be enough for git to consider it a move

@eric-wieser
Copy link
Member

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Nov 10, 2023

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Nov 10, 2023
@ocfnash
Copy link
Contributor Author

ocfnash commented Nov 10, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Nov 10, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 10, 2023
…a.Eigenspace.Triangularizable` (#8318)

The motivation is that I wish to add further results about triangularizability of linear endomorphisms and I claim this file is a natural home.

This rename-only PR exists to prevent breaking 'nightly-testing'.
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 10, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: rename LinearAlgebra.Eigenspace.IsAlgClosed to LinearAlgebra.Eigenspace.Triangularizable [Merged by Bors] - chore: rename LinearAlgebra.Eigenspace.IsAlgClosed to LinearAlgebra.Eigenspace.Triangularizable Nov 10, 2023
@mathlib-bors mathlib-bors bot closed this Nov 10, 2023
@mathlib-bors mathlib-bors bot deleted the ocfnash/rename_eigen_isalgclosed branch November 10, 2023 16:50
grunweg pushed a commit that referenced this pull request Dec 15, 2023
…a.Eigenspace.Triangularizable` (#8318)

The motivation is that I wish to add further results about triangularizability of linear endomorphisms and I claim this file is a natural home.

This rename-only PR exists to prevent breaking 'nightly-testing'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants