[Merged by Bors] - chore: add some Unique instances #8500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…leanprover-community/mathlib4 into zjj/directLimitAndTensorProduct
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
|
!bench |
|
Here are the benchmark results for commit a9807db. |
alreadydone
force-pushed
the
IsEmptyUnique_instances
branch
from
a9807db
to
d231157
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
alreadydone
changed the title
alreadydone
added
the
awaiting-review
|
Because Logic/Unique's dependency is lighter after #8510, I now import it into Data/Quot in favor of easier constructions of the Unique instances using the Subsingleton and Inhabited instances there. |
1 task
|
✌️ alreadydone can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
The aim is to remove some extraneous Nonempty assumptions in Algebra/DirectLimit. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com> Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
alexkeizer
pushed a commit
that referenced
this pull request
Nov 21, 2023
The aim is to remove some extraneous Nonempty assumptions in Algebra/DirectLimit. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com> Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
grunweg
pushed a commit
that referenced
this pull request
Dec 15, 2023
The aim is to remove some extraneous Nonempty assumptions in Algebra/DirectLimit. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com> Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
The aim is to remove some extraneous Nonempty assumptions in Algebra/DirectLimit. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com> Co-authored-by: Jujian Zhang <jujian.zhang1998@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is to remove some extraneous Nonempty assumptions in Algebra/DirectLimit.