Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: various linear algebra results #8572

Closed
wants to merge 4 commits into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Nov 22, 2023


I have split these out from #8583 to aid its review. I believe these changes make sense in their own right.

Open in Gitpod

@ocfnash ocfnash added WIP Work in progress awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Nov 22, 2023
@ocfnash ocfnash changed the title feat: remove triangularizability assumption from proof that Cartan subalgebras are Abelian feat: various linear algebra results Nov 22, 2023
@ocfnash ocfnash added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Nov 23, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 24, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 24, 2023
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 24, 2023

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Nov 24, 2023
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 24, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: various linear algebra results [Merged by Bors] - feat: various linear algebra results Nov 24, 2023
@mathlib-bors mathlib-bors bot closed this Nov 24, 2023
@mathlib-bors mathlib-bors bot deleted the ocfnash/cartan_abelian2 branch November 24, 2023 12:52

/-- If `A` is an `R`-algebra, any `R`-linear map `M₁ → M₂` naturally induces an `A`-linear map
`A ⊗ M₁ → A ⊗ M₂`. -/
def extendScalars : A ⊗[R] M₁ →ₗ[A] A ⊗[R] M₂ :=
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my shame I have just discovered that this duplicates LinearMap.baseChange.

I will follow up with a PR to remove this definition (and probably expand the comment on LinearMap.baseChange to include the words "extension of scalars").

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP here #8617

awueth pushed a commit that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants