[Merged by Bors] - chore: delete LinearMap.extendScalars which duplicates LinearMap.baseChange
#8617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tency with `LinearMap.baseChange`
ocfnash
added
WIP
leanprover-community-mathlib4-bot
added
blocked-by-other-PR
|
This PR/issue depends on: |
ocfnash
commented
Nov 24, 2023
|
|
||
| /-- If `A` is an `R`-algebra, any `R`-linear map `M₁ → M₂` naturally induces an `A`-linear map | ||
| `A ⊗ M₁ → A ⊗ M₂`. -/ | ||
| def extendScalars : A ⊗[R] M₁ →ₗ[A] A ⊗[R] M₂ := |
There was a problem hiding this comment.
This is the key point: this definition is an exact duplicate of LinearMap.baseChange and so should not have been introduced.
ocfnash
added
awaiting-review
leanprover-community-mathlib4-bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 25, 2023
…aseChange` (#8617) For consistency, we also rename `Submodule.extendScalars` to `Submodule.baseChange` and likewise for `LieSubmodule`.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
LinearMap.extendScalars which duplicates LinearMap.baseChangeLinearMap.extendScalars which duplicates LinearMap.baseChange
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
…aseChange` (#8617) For consistency, we also rename `Submodule.extendScalars` to `Submodule.baseChange` and likewise for `LieSubmodule`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, we also rename
Submodule.extendScalarstoSubmodule.baseChangeand likewise forLieSubmodule.The interacts with #8583 which I think it is simpler to merge first, and thus I will mark as a dependency here.