Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Add Polynomial.separable_map'. #8680

Closed
wants to merge 3 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Nov 28, 2023


Open in Gitpod

@erdOne erdOne added the awaiting-review The author would like community review of the PR label Nov 28, 2023
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is strictly more general than the actual separable_map, right? In this case this should be the umprimed version (maybe you can even inline the proof of the weak case and only keep the more general one).

@riccardobrasca
Copy link
Member

riccardobrasca commented Nov 28, 2023

This is strictly more general than the actual separable_map, right? In this case this should be the umprimed version (maybe you can even inline the proof of the weak case and only keep the more general one).

I mean something like

attribute [local instance] Ideal.Quotient.field in
lemma separable_map {S} [CommRing S] [Nontrivial S] (f : F →+* S) {p : F[X]} :
    (p.map f).Separable ↔ p.Separable := by
  refine ⟨fun H ↦ ?_, fun H ↦ H.map⟩
  obtain ⟨m, hm⟩ := Ideal.exists_maximal S
  have := Separable.map H (f := Ideal.Quotient.mk m)
  rwa [map_map, separable_def, derivative_map, isCoprime_map] at this

@riccardobrasca
Copy link
Member

Thanks!

bors +

@mathlib-bors
Copy link

mathlib-bors bot commented Nov 28, 2023

Did you mean "r+"?

@riccardobrasca
Copy link
Member

Did you mean "r+"?

Almost, but thanks bors!!

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Nov 28, 2023

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Nov 28, 2023
@erdOne
Copy link
Member Author

erdOne commented Nov 28, 2023

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Nov 28, 2023
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 28, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Add Polynomial.separable_map'. [Merged by Bors] - feat: Add Polynomial.separable_map'. Nov 28, 2023
@mathlib-bors mathlib-bors bot closed this Nov 28, 2023
@mathlib-bors mathlib-bors bot deleted the erd1/separable_map branch November 28, 2023 22:30
awueth pushed a commit that referenced this pull request Dec 19, 2023
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants