Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(FDeriv): use structure #8907

Closed
wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 8, 2023

This way we can easily change the definition so that it works for topological vector spaces without generalizing any of the theorems right away.


Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Dec 8, 2023
@eric-wieser
Copy link
Member

This way we can easily change the definition so that it works for topological vector spaces without generalizing any of the theorems right away.

What do you mean by this? Are you envisaging replacing it with a different structure? If so, the .1s and mks you use in the proof should probably be referred to by name and called of_isLittleO, respectively.

@urkud
Copy link
Member Author

urkud commented Dec 8, 2023

This way we can easily change the definition so that it works for topological vector spaces without generalizing any of the theorems right away.

What do you mean by this? Are you envisaging replacing it with a different structure?

Yes, I want to generalize the definition so that it works for maps between topological vector spaces, without generalizing all the lemmas immediately.

If so, the .1s and mks you use in the proof should probably be referred to by name and called of_isLittleO, respectively.

You're right and I was lazy. Fixed.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Dec 9, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 9, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 9, 2023
@sgouezel
Copy link
Contributor

bors r+
I've wanted to refactor derivatives for a long time, so if this helps you do it it's definitely a move in the right direction!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 20, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 20, 2023
This way we can easily change the definition so that it works for topological vector spaces without generalizing any of the theorems right away.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 20, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(FDeriv): use structure [Merged by Bors] - refactor(FDeriv): use structure Dec 20, 2023
@mathlib-bors mathlib-bors bot closed this Dec 20, 2023
@mathlib-bors mathlib-bors bot deleted the YK-fderiv-struct branch December 20, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants