Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(*Deriv*): golf #8899

Closed
wants to merge 1 commit into from
Closed

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 8, 2023

Assorted golf I did while working on a refactor. Submitting as a separate PR.

  • Move not_differentiableAt_abs_zero to Calculus.Deriv.Add, golf.
  • Rename HasFDerivWithinAt_of_nhdsWithin_eq_bot to HasFDerivWithinAt.of_nhdsWithin_eq_bot, golf.
  • Protect Filter.EventuallyEq.rfl.
  • Golf here and there.

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Dec 8, 2023
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the new proofs are much nicer; thanks for doing this! Looks good to me.

(I'd rate my overall confidence as medium.)

dsimp only [DifferentiableWithinAt] at h
rw [dif_pos h]
· exact .of_nhdsWithin_eq_bot H
· unfold DifferentiableWithinAt at h
Copy link
Collaborator

@grunweg grunweg Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would also work. Not sure if this is better.

Suggested change
· unfold DifferentiableWithinAt at h
· rw [DifferentiableWithinAt] at h

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I made a copy-paste typo. Corrected.

@sgouezel
Copy link
Contributor

sgouezel commented Dec 9, 2023

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 9, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 9, 2023
Assorted golf I did while working on a refactor. Submitting as a separate PR.

- Move `not_differentiableAt_abs_zero` to `Calculus.Deriv.Add`, golf.
- Rename `HasFDerivWithinAt_of_nhdsWithin_eq_bot` to `HasFDerivWithinAt.of_nhdsWithin_eq_bot`, golf.
- Protect `Filter.EventuallyEq.rfl`.
- Golf here and there.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 9, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(*Deriv*): golf [Merged by Bors] - chore(*Deriv*): golf Dec 9, 2023
@mathlib-bors mathlib-bors bot closed this Dec 9, 2023
@mathlib-bors mathlib-bors bot deleted the YK-deriv-golf branch December 9, 2023 13:26
awueth pushed a commit that referenced this pull request Dec 19, 2023
Assorted golf I did while working on a refactor. Submitting as a separate PR.

- Move `not_differentiableAt_abs_zero` to `Calculus.Deriv.Add`, golf.
- Rename `HasFDerivWithinAt_of_nhdsWithin_eq_bot` to `HasFDerivWithinAt.of_nhdsWithin_eq_bot`, golf.
- Protect `Filter.EventuallyEq.rfl`.
- Golf here and there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants