New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(*Deriv*): golf #8899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the new proofs are much nicer; thanks for doing this! Looks good to me.
(I'd rate my overall confidence as medium.)
dsimp only [DifferentiableWithinAt] at h | ||
rw [dif_pos h] | ||
· exact .of_nhdsWithin_eq_bot H | ||
· unfold DifferentiableWithinAt at h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would also work. Not sure if this is better.
· unfold DifferentiableWithinAt at h | |
· rw [DifferentiableWithinAt] at h |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I made a copy-paste typo. Corrected.
bors r+ |
Assorted golf I did while working on a refactor. Submitting as a separate PR. - Move `not_differentiableAt_abs_zero` to `Calculus.Deriv.Add`, golf. - Rename `HasFDerivWithinAt_of_nhdsWithin_eq_bot` to `HasFDerivWithinAt.of_nhdsWithin_eq_bot`, golf. - Protect `Filter.EventuallyEq.rfl`. - Golf here and there.
Pull request successfully merged into master. Build succeeded: |
Assorted golf I did while working on a refactor. Submitting as a separate PR. - Move `not_differentiableAt_abs_zero` to `Calculus.Deriv.Add`, golf. - Rename `HasFDerivWithinAt_of_nhdsWithin_eq_bot` to `HasFDerivWithinAt.of_nhdsWithin_eq_bot`, golf. - Protect `Filter.EventuallyEq.rfl`. - Golf here and there.
Assorted golf I did while working on a refactor. Submitting as a separate PR.
not_differentiableAt_abs_zero
toCalculus.Deriv.Add
, golf.HasFDerivWithinAt_of_nhdsWithin_eq_bot
toHasFDerivWithinAt.of_nhdsWithin_eq_bot
, golf.Filter.EventuallyEq.rfl
.