[Merged by Bors] - feat: Restriction of galois group onto integrally closed subrings. #9113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
erdOne
commented
Dec 16, 2023
erdOne
commented
erdOne
added
awaiting-review
riccardobrasca
approved these changes
Dec 17, 2023
| # Restriction of various maps between fields to integrally closed subrings. | ||
|
|
||
| ## Main definition | ||
| - `galRestrict`: The restriction `Aut(L/K) → Aut(B/A)` as an `MulEquiv` in an ALKB setup. |
There was a problem hiding this comment.
Suggested change
| - `galRestrict`: The restriction `Aut(L/K) → Aut(B/A)` as an `MulEquiv` in an ALKB setup. | |
| - `galRestrictHom`: The restriction `Aut(L/K) → Aut(B/A)` as an `MulEquiv` in an ALKB setup. |
And what does ALKB mean?
There was a problem hiding this comment.
I guess it means A a subring of K and B a subring of L?
There was a problem hiding this comment.
galRestrict is the main definition to use. Updated the docstring of galRestrictHom to make it clearer.
Also added a sentence in the module docstring explaining AKLB.
|
Is it worth also combining this with |
CBirkbeck
reviewed
Dec 17, 2023
|
✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
…9113) Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
…9113) Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.