New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Define intNorm
and intTrace
.
#9265
Conversation
erdOne
commented
Dec 25, 2023
The connection to |
|
||
section trace | ||
|
||
/-- The restriction of the trace on `L/K` restricted onto `B/A` in an AKLB setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "AKLB setup" standard terminology (in mathlib)?
It's the first time I see it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this file, we assume `A` is an integrally closed domain; `K` is the fraction ring of `A`;
`L` is a finite (separable) extension of `K`; `B` is the integral closure of `A` in `L`.
We call this the AKLB setup.
is in the module docstring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. That makes sense. But I'm not sure that we should assume this kind of info in docstrings, since they show up outside the context of the file.
Maybe add
/-- The restriction of the trace on `L/K` restricted onto `B/A` in an AKLB setup. | |
/-- The restriction of the trace on `L/K` restricted onto `B/A` in an AKLB setup (see module docstring). |
for now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this terminology also appears in some literature, for example Ash's A Course In Algebraic Number Theory.
Maybe I can expand the docstring into a library note in a future PR and reference it here.
Have we implemented library note in lean4 yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the docstring as is for now. This is an auxiliary definition that probably won't be used outside this file.
LGTM. How do the results in this PR relate to what Riccardo did in |
Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Xavier Roblot <46200072+xroblot@users.noreply.github.com>
The connection needs some other stuff (for example #9444) and will come in a later PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Pull request successfully merged into master. Build succeeded: |
intNorm
and intTrace
.intNorm
and intTrace
.
I somehow missed this PR, sorry. Anyway the new intNorm could completely replace RingOfIntegers.norm, right? |
Maybe yes. This might not work when |