Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(AlgebraicTopology/SingularSet): factor topology out of SimplicialSet into new file #9428

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore(AlgebraicTopology/SingularSet): factor topology out of SimplicialSet into new file #9428

wants to merge 4 commits into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Jan 4, 2024
@jcommelin jcommelin changed the title feat(AlgebraicTopology/SingularSet): factor topology out of SimplicialSet into new file chore(AlgebraicTopology/SingularSet): factor topology out of SimplicialSet into new file Jan 4, 2024
@jcommelin jcommelin mentioned this pull request Jan 4, 2024
Closed
YaelDillies
YaelDillies reviewed Jan 6, 2024
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this but an algebraic topology maintainer (@adamtopaz ?) should have a look.

Mathlib/AlgebraicTopology/SingularSet.lean Outdated
Comment on lines 2 to 4
Copyright (c) 2024 Johan Commelin. All rights reserved.
Released under Apache 2.0 license as described in the file LICENSE.
Authors: Johan Commelin, Scott Morrison, Adam Topaz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure the year is correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be the year that this file was created?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I guess we've argued this before. I always take it to be the year the oldest definition/lemma of the file was created.

@YaelDillies
Copy link
Collaborator

Please an algebraic topology maintainer sign off!

maintainer merge

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@joelriou
Copy link
Collaborator

joelriou commented Jan 9, 2024

This looks good to me. There is one issue though (which can fixed in a later PR): it seems that the functors like TopCat.toSSet : TopCat ⥤ SSet are currently defined only for topological spaces in Type 0.

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Jan 9, 2024

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jan 9, 2024
@jcommelin
Copy link
Member Author

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jan 9, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 9, 2024
@jcommelin
chore(AlgebraicTopology/SingularSet): factor topology out of `Simplic…
40c4f80 
…ialSet` into new file (#9428)
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 9, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(AlgebraicTopology/SingularSet): factor topology out of SimplicialSet into new file [Merged by Bors] - chore(AlgebraicTopology/SingularSet): factor topology out of SimplicialSet into new file Jan 9, 2024
@mathlib-bors mathlib-bors bot closed this Jan 9, 2024
@mathlib-bors mathlib-bors bot deleted the singular-set branch January 9, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies left review comments

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcommelin @YaelDillies @joelriou