Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: Rename over-general names #9429

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - chore: Rename over-general names #9429

wants to merge 5 commits into from

Conversation

winstonyin
Copy link
Collaborator

Items 1-3 in reference Zulip

Rename chartedSpace, smoothMfldWithCorners, and funLike.

Open in Gitpod

@winstonyin winstonyin added the awaiting-review The author would like community review of the PR label Jan 4, 2024
@winstonyin winstonyin added the easy < 20s of review time. See the lifecycle page for guidelines. label Jan 4, 2024
eric-wieser
eric-wieser approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Thanks! This isn't a bit of the library I use much, so I'll let a manifold user check my bike shed color suggestion was ok.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

🚀 Pull request has been placed on the maintainer queue by eric-wieser.

@urkud
Copy link
Member

urkud commented Jan 4, 2024

Thanks! 🎉
bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 4, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 4, 2024
@winstonyin
chore: Rename over-general names (#9429)
8e19af9 
Items 1-3 in [reference Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Assorted.20renames/near/411096017)

Rename `chartedSpace`, `smoothMfldWithCorners`, and `funLike`.
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 4, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Rename over-general names [Merged by Bors] - chore: Rename over-general names Jan 4, 2024
@mathlib-bors mathlib-bors bot closed this Jan 4, 2024
@mathlib-bors mathlib-bors bot deleted the wy_rename branch January 4, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@winstonyin @urkud @eric-wieser