Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: Rename over-general names #9429

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions Mathlib/Geometry/Manifold/Instances/Sphere.lean
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ theorem stereographic'_target {n : ℕ} [Fact (finrank ℝ E = n + 1)] (v : sphe

/-- The unit sphere in an `n + 1`-dimensional inner product space `E` is a charted space
modelled on the Euclidean space of dimension `n`. -/
instance chartedSpace {n : ℕ} [Fact (finrank ℝ E = n + 1)] :
instance EuclideanSpace.instChartedSpaceSphere {n : ℕ} [Fact (finrank ℝ E = n + 1)] :
ChartedSpace (EuclideanSpace ℝ (Fin n)) (sphere (0 : E) 1) where
atlas := {f | ∃ v : sphere (0 : E) 1, f = stereographic' n v}
chartAt v := stereographic' n (-v)
Expand Down Expand Up @@ -411,7 +411,7 @@ theorem stereographic'_symm_apply {n : ℕ} [Fact (finrank ℝ E = n + 1)] (v :

/-- The unit sphere in an `n + 1`-dimensional inner product space `E` is a smooth manifold,
modelled on the Euclidean space of dimension `n`. -/
instance smoothMfldWithCorners {n : ℕ} [Fact (finrank ℝ E = n + 1)] :
instance EuclideanSpace.instSmoothManifoldWithCornersSphere {n : ℕ} [Fact (finrank ℝ E = n + 1)] :
SmoothManifoldWithCorners (𝓡 n) (sphere (0 : E) 1) :=
smoothManifoldWithCorners_of_contDiffOn (𝓡 n) (sphere (0 : E) 1)
(by
Expand Down Expand Up @@ -443,7 +443,7 @@ instance smoothMfldWithCorners {n : ℕ} [Fact (finrank ℝ E = n + 1)] :
theorem contMDiff_coe_sphere {n : ℕ} [Fact (finrank ℝ E = n + 1)] :
ContMDiff (𝓡 n) 𝓘(ℝ, E) ∞ ((↑) : sphere (0 : E) 1 → E) := by
-- Porting note: trouble with filling these implicit variables in the instance
have := smoothMfldWithCorners (E := E) (n := n)
have := EuclideanSpace.instSmoothManifoldWithCornersSphere (E := E) (n := n)
rw [contMDiff_iff]
constructor
· exact continuous_subtype_val
Expand Down Expand Up @@ -589,10 +589,10 @@ attribute [local instance] finrank_real_complex_fact'
/-- The unit circle in `ℂ` is a charted space modelled on `EuclideanSpace ℝ (Fin 1)`. This
follows by definition from the corresponding result for `Metric.Sphere`. -/
instance : ChartedSpace (EuclideanSpace ℝ (Fin 1)) circle :=
chartedSpace
EuclideanSpace.instChartedSpaceSphere

instance : SmoothManifoldWithCorners (𝓡 1) circle :=
smoothMfldWithCorners (E := ℂ)
EuclideanSpace.instSmoothManifoldWithCornersSphere (E := ℂ)

/-- The unit circle in `ℂ` is a Lie group. -/
instance : LieGroup (𝓡 1) circle where
Expand Down
2 changes: 1 addition & 1 deletion Mathlib/NumberTheory/LegendreSymbol/MulCharacter.lean
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ structure MulChar extends MonoidHom R R' where
map_nonunit' : ∀ a : R, ¬IsUnit a → toFun a = 0
#align mul_char MulChar

instance funLike : FunLike (MulChar R R') R (fun _ => R') :=
instance MulChar.instFunLike : FunLike (MulChar R R') R (fun _ => R') :=
⟨fun χ => χ.toFun,
fun χ₀ χ₁ h => by cases χ₀; cases χ₁; congr; apply MonoidHom.ext (fun _ => congr_fun h _)⟩

Expand Down
2 changes: 1 addition & 1 deletion docs/overview.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ Geometry:
tangent bundle: 'TangentBundle'
tangent map: 'tangentMap'
Lie group: 'LieGroup'
sphere: 'smoothMfldWithCorners'
sphere: 'EuclideanSpace.instSmoothManifoldWithCornersSphere'

Algebraic geometry:
prime spectrum: 'PrimeSpectrum'
Expand Down