[Merged by Bors] - chore: adaptations for leanprover/lean4#3124 #9500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
eric-wieser
reviewed
Jan 11, 2024
| nth_rewrite 2 [← swap_inv] | ||
| nth_rewrite 3 [← swap_inv] |
There was a problem hiding this comment.
Did simprocs really make a difference here?
There was a problem hiding this comment.
No, this one is from leanprover/lean4#2539, which landed in nightly-2024-01-03.
I thought we already had an adaptation PR for that, so perhaps this is a change that landed in Mathlib master and so was ad-hoc fixed on nightly-testing in the meantime.
I propose just rolling it in here to avoid the overhead of a separate PR.
eric-wieser
reviewed
Jan 11, 2024
|
!bench |
|
Here are the benchmark results for commit 5be9c98.Found no runs to compare against. |
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
These are adaptations required for Leo's implementation of simprocs from leanprover/lean4#3124. This is a PR to `bump/v4.6.0`. Before it can be merged we need to merge - [x] leanprover-community/batteries#496 - [x] leanprover-community/aesop#93 and then to update the lakefile so both dependencies point at the `bump/v4.6.0` branches. I've updated a number of Mathlib tactics to adjust to the new type signatures in the simplifier, and these changes need to be reviewed carefully. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into bump/v4.6.0. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are adaptations required for Leo's implementation of simprocs from leanprover/lean4#3124.
This is a PR to
bump/v4.6.0. Before it can be merged we need to mergeand then to update the lakefile so both dependencies point at the
bump/v4.6.0branches.I've updated a number of Mathlib tactics to adjust to the new type signatures in the simplifier, and these changes need to be reviewed carefully.