Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - perf (Algebra.DirectLimit): use suppress_compilation #9664

Closed
wants to merge 1 commit into from

Conversation

mattrobball
Copy link
Collaborator

Uses suppress_compilation to lessen the load on Lean when building the file.


Open in Gitpod

@mattrobball
Copy link
Collaborator Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 115afa3.
There were significant changes against commit 3e1faeb:

  Benchmark                                                           Metric         Change
  =========================================================================================
+ ~Mathlib.Algebra.DirectLimit                                        instructions   -14.8%
+ ~Mathlib.CategoryTheory.Limits.FilteredColimitCommutesFiniteLimit   instructions   -15.8%

@mattrobball mattrobball added the awaiting-review The author would like community review of the PR label Jan 12, 2024
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems plausible to me. (I'm not an expert, though.)

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
Uses `suppress_compilation` to lessen the load on Lean when building the file.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 13, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
Uses `suppress_compilation` to lessen the load on Lean when building the file.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title perf (Algebra.DirectLimit): use suppress_compilation [Merged by Bors] - perf (Algebra.DirectLimit): use suppress_compilation Feb 13, 2024
@mathlib-bors mathlib-bors bot closed this Feb 13, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/direct_limit branch February 13, 2024 11:23
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
Uses `suppress_compilation` to lessen the load on Lean when building the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants