New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: arctangent addition and Machin's formula for π #9847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a look and left a few comments, mostly about style. (Some are certainly subjective.)
LGTM, but someone more familiar with this part of the library might want to take another look. maintainer merge |
🚀 Pull request has been placed on the maintainer queue by jcommelin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
bors r+ |
`four_mul_arctan_inv_5_sub_arctan_inv_239` is theorem 1 in my own #6091.
Build failed (retrying...): |
`four_mul_arctan_inv_5_sub_arctan_inv_239` is theorem 1 in my own #6091.
Build failed (retrying...): |
`four_mul_arctan_inv_5_sub_arctan_inv_239` is theorem 1 in my own #6091.
Pull request successfully merged into master. Build succeeded:
|
`four_mul_arctan_inv_5_sub_arctan_inv_239` is theorem 1 in my own #6091.
`four_mul_arctan_inv_5_sub_arctan_inv_239` is theorem 1 in my own #6091.
four_mul_arctan_inv_5_sub_arctan_inv_239
is theorem 1 in my own #6091.