Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: arctangent addition and Machin's formula for π #9847

Closed
wants to merge 5 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

four_mul_arctan_inv_5_sub_arctan_inv_239 is theorem 1 in my own #6091.


Open in Gitpod

@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Jan 19, 2024
Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look and left a few comments, mostly about style. (Some are certainly subjective.)

@jcommelin
Copy link
Member

LGTM, but someone more familiar with this part of the library might want to take another look.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by jcommelin.

Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Feb 13, 2024
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 13, 2024
@sgouezel
Copy link
Contributor

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
`four_mul_arctan_inv_5_sub_arctan_inv_239` is theorem 1 in my own #6091.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
`four_mul_arctan_inv_5_sub_arctan_inv_239` is theorem 1 in my own #6091.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 13, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Feb 13, 2024
`four_mul_arctan_inv_5_sub_arctan_inv_239` is theorem 1 in my own #6091.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 14, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: arctangent addition and Machin's formula for π [Merged by Bors] - feat: arctangent addition and Machin's formula for π Feb 14, 2024
@mathlib-bors mathlib-bors bot closed this Feb 14, 2024
@mathlib-bors mathlib-bors bot deleted the machin branch February 14, 2024 00:26
riccardobrasca pushed a commit that referenced this pull request Feb 18, 2024
`four_mul_arctan_inv_5_sub_arctan_inv_239` is theorem 1 in my own #6091.
dagurtomas pushed a commit that referenced this pull request Mar 22, 2024
`four_mul_arctan_inv_5_sub_arctan_inv_239` is theorem 1 in my own #6091.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants