Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use match with Decidable in List instances #271

Closed

Conversation

collares
Copy link
Contributor

@kbuzzard
Copy link
Member

Of course the correct question is "why is this happening" :-) If that could be isolated and fixed, this PR wouldn't be needed!

@collares
Copy link
Contributor Author

True! In the meantime, the forall/exists instances in Logic.lean and Data/Option/Basic.lean probably should have the same workaround applied to them too.

@github-actions github-actions bot added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Sep 23, 2023
@collares
Copy link
Contributor Author

(A previous stupid comment of mine was deleted)

@kim-em
Copy link
Collaborator

kim-em commented Sep 24, 2023

This is worse than the issue described in leanprover/lean4#2552: here it's not cases that is a problem, but merely if.

Would you be able to open a lean4 issue demonstrating this problem?

Hacky workarounds like these need to be accompanied by links in the source code to the relevant issues, so we can undo them later.

@collares
Copy link
Contributor Author

Thanks for not blindly merging. Turns out I hadn't fully reverted some other changes, and this PR is not helpful for fixing the Zulip issues. Closing.

@collares collares closed this Sep 24, 2023
@collares collares deleted the work-around-2552 branch September 24, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review This PR is ready for review; the author thinks it is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants