Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass modal variable to modal-partial-end #98

Open
Nuranto opened this issue Feb 16, 2019 · 0 comments
Open

Pass modal variable to modal-partial-end #98

Nuranto opened this issue Feb 16, 2019 · 0 comments

Comments

@Nuranto
Copy link

Nuranto commented Feb 16, 2019

In class ModalRenderer, you pass $modal to start method, and not end. However, it could be usefull in end method too.

public function end()
    {
        return view('leantony::modal.modal-partial-end');
    }

=>

public function end($data)
    {
        return view('leantony::modal.modal-partial-end', ['modal' => $data]);
    }

plus replace all {!! Modal::end() !!} occurences with {!! Modal::end($modal) !!}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant