Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage ws parsers #23

Closed
rauchg opened this issue Mar 2, 2012 · 6 comments
Closed

Leverage ws parsers #23

rauchg opened this issue Mar 2, 2012 · 6 comments
Assignees
@einaros

Comments

@rauchg
Copy link
Contributor

rauchg commented Mar 2, 2012

No description provided.

@ghost ghost assigned einaros Mar 2, 2012
@nicokaiser
Copy link
Contributor

Do you mean something like this?

https://github.com/nicokaiser/websocket.io/commit/3ebc2c8280be69137fdcfa5fa1c7e4ad480f3766

(see https://github.com/nicokaiser/websocket.io/tree/wsparsers )

@rauchg
Copy link
Contributor Author

rauchg commented Mar 27, 2012

Indeed!

@nicokaiser
Copy link
Contributor

However it renders the parser tests useless, so I removed them. Then again, the ws parser is tested in the ws module itself...

@rauchg
Copy link
Contributor Author

rauchg commented Mar 27, 2012

Yep that's good. websocket.io is an interface, so we should test the interface.

@nicokaiser
Copy link
Contributor

(btw, I took most of the code from @einaros' socket.io fork)

@nicokaiser nicokaiser mentioned this issue Mar 27, 2012
Merged
@einaros
Copy link
Contributor

einaros commented Mar 27, 2012

That's exactly why I added the handleUpgrade() method in WebSocketServer back in january. :)

@rauchg rauchg closed this as completed Jul 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@einaros einaros

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rauchg @nicokaiser @einaros