Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Room API Throws an error #71

Closed
bundacia opened this issue Dec 2, 2016 · 0 comments
Closed

Create Room API Throws an error #71

bundacia opened this issue Dec 2, 2016 · 0 comments
Assignees
Labels

Comments

@bundacia
Copy link

bundacia commented Dec 2, 2016

When trying to launch a new cycle the cycleLaunchedWorker in game is getting an error

Error

Error: TypeError::Cannot read property '_id' of undefined

Full Stacktrace

cycleLaunched job 1 (attempt=1) failed: Error: TypeError::Cannot read property '_id' of undefined
    at /Users/trevor/lg/game/server/clients/ChatClient.js:92:33
    at run (/Users/trevor/lg/game/node_modules/core-js/modules/es6.promise.js:87:22)
    at /Users/trevor/lg/game/node_modules/core-js/modules/es6.promise.js:100:28
    at flush (/Users/trevor/lg/game/node_modules/core-js/modules/_microtask.js:18:9)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)
From previous event:
    at /Users/trevor/lg/game/node_modules/bull/lib/queue.js:666:30
From previous event:
    at Queue.processJob (/Users/trevor/lg/game/node_modules/bull/lib/queue.js:664:24)
    at normal_reply (/Users/trevor/lg/game/node_modules/bull/node_modules/redis/index.js:714:21)
    at RedisClient.return_reply (/Users/trevor/lg/game/node_modules/bull/node_modules/redis/index.js:816:9)
    at JavascriptRedisParser.Parser.returnReply (/Users/trevor/lg/game/node_modules/bull/node_modules/redis/index.js:188:18)
    at JavascriptRedisParser.execute (/Users/trevor/lg/game/node_modules/redis-parser/lib/parser.js:430:12)
    at Socket.<anonymous> (/Users/trevor/lg/game/node_modules/bull/node_modules/redis/index.js:267:27)
    at emitOne (events.js:90:13)
    at Socket.emit (events.js:182:7)
    at readableAddChunk (_stream_readable.js:153:18)
    at Socket.Readable.push (_stream_readable.js:111:10)
    at TCP.onread (net.js:534:20)
From previous event:
    at /Users/trevor/lg/game/node_modules/bull/lib/queue.js:588:10
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)
Forming teams for cycle 21 of chapter 0edb08e1-d8ab-4318-8363-0711a7f9edbb

Cause

It looks like RocketChat.saveRoomTopic takes a user as third argument and we're not passing one when we call it in the API action that creates a room.

@bundacia bundacia self-assigned this Dec 2, 2016
@bundacia bundacia added the bug label Dec 2, 2016
bundacia added a commit that referenced this issue Dec 2, 2016
This must be new since the upgrade.

Fixes #71
jeffreywescott pushed a commit that referenced this issue Jan 6, 2017
This must be new since the upgrade.

Fixes #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant