Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors submitting partial project reviews #80

Closed
bundacia opened this issue Aug 17, 2016 · 0 comments
Closed

Errors submitting partial project reviews #80

bundacia opened this issue Aug 17, 2016 · 0 comments
Assignees
@bundacia
Labels
bug

Comments

@bundacia
Copy link
Contributor

@bundacia commented on Wed Jul 27 2016

I tried submitting completeness and quality scores separately and got a error each time. But then my review was actually saved successfully.

_1__rocket_chat
@bundacia bundacia mentioned this issue Aug 17, 2016
Closed
bundacia added a commit that referenced this issue Aug 17, 2016
@bundacia
Only send the responses the user specified
1c1de3d 
We were sending 2 responses every time someone issued the `/review`
command, even if they were only recording a response for one question.

For example:

```
/review #happy-frog -c 99
```

Would cause game-cli to send 2 responses to the game service one for the
completness question with the responseParams `['99']`, and another for the quality
question with the responseParams `[null]`

Fixes #80
@bundacia bundacia self-assigned this Aug 17, 2016
@bundacia bundacia mentioned this issue Aug 17, 2016
Merged
@bundacia bundacia added the bug label Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bundacia bundacia

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bundacia