Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it more like library #32

Closed
GoogleCodeExporter opened this issue Mar 21, 2015 · 7 comments
Closed

Make it more like library #32

GoogleCodeExporter opened this issue Mar 21, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link


It is not issue, just a feature request.
1. Ability to change default path, now tsip_api.js load everything from /src 
path. It possible to change it of course, but it will be nice to have straight 
way for this, may be root path as param?
2. Minified version

Original issue reported on code.google.com by i...@fomine.com on 31 May 2012 at 5:31

@GoogleCodeExporter
Copy link
Author

Original comment by boss...@yahoo.fr on 1 Jun 2012 at 12:44

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

I have a patch I can submit for this that will at least do the path part as 
well as all the async loading of the scripts...allowing you to wait for the 
scripts to completely load. Interested?

Original comment by alskiont...@gmail.com on 5 Sep 2012 at 4:51

@GoogleCodeExporter
Copy link
Author

@alskiontheweb
Yep

Original comment by boss...@yahoo.fr on 6 Sep 2012 at 5:45

@GoogleCodeExporter
Copy link
Author

Here's the patch. You will probably want to clean it up a little bit. 
Basically, it's looking to see if you have window.tsip_api_root set and if so, 
loads the files from there. The async loading part I can roll as a different 
patch but it's more or less a new layer on top. I'll try and get that set.

One other thing that may be of interest to you is that I have a GWT wrapper 
around the SIPML5 stack as well. It is using JSNI to hide some of the 
complexities. Interested? The one down side possibly is that I'm using Maven to 
build it out. There is a GWT test UI with it as well. There are also a few 
other changes I have patched into the library, things like specifying the peer 
connection configuration, etc. Do you want patches for those?

Original comment by alskiont...@gmail.com on 6 Sep 2012 at 3:22

Attachments:

@GoogleCodeExporter
Copy link
Author

Here's an alternate version of the patch that includes a callback to a window 
based function, tsip_script_onload, when the API scripts are loaded. This can 
be used to put a callback to monitor the load state of all the scripts. 

Original comment by alskiont...@gmail.com on 6 Sep 2012 at 4:10

Attachments:

@GoogleCodeExporter
Copy link
Author

Hi alskiont 
I need to inclute in a GWT Project this sipml5.
it's possible to you to give the GWT wrapper or give some pointers?

Original comment by rgo...@observit.pt on 25 Sep 2012 at 10:42

@GoogleCodeExporter
Copy link
Author

Fixed by SVN r144: http://code.google.com/p/sipml5/wiki/Downloads

Original comment by boss...@yahoo.fr on 17 Dec 2012 at 7:00

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant