Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add user" and "Add teacher" should not appear until after a facility exists #193

Closed
bcipolli opened this issue Jul 6, 2013 · 3 comments
Assignees
Milestone

Comments

@bcipolli
Copy link
Contributor

bcipolli commented Jul 6, 2013

Suggestion:

  • Have "Add Facility", hide "add user" and "add teacher"
  • Efficient from securesync/api_views:status to check if Facility.objects.count() > 0
@ghost ghost assigned wangguan59 Jul 6, 2013
@wangguan59
Copy link
Contributor

Jamie said this might be little tricky because it would be interact with cache. The top nav bar is under base_distributed.html . If I modify that, it would check every time the page loads, which is not very efficient. Do you have any suggestions?

@bcipolli
Copy link
Contributor Author

I don't see any problem; the navbar is controlled through AJAX requests already, to have good performance. No interaction with caching.

My suggestion is in the body of the pull request; in the code to get navbar information through the API, have a flag for facility_exists, that checks if Facility.objects.count() > 0. From the client-side, use that flag appropriately.

Nothing conceptually different than what's already done in the navbar.

@bcipolli
Copy link
Contributor Author

@wangguan59 note the milestone: this is not targeted for KA Lite 0.10, so no rush to implement.

@bcipolli bcipolli modified the milestones: Nalanda RCT Stage 1, KA Lite v0.12.1 Mar 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants