-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New administrative interface #1306
Conversation
…tools), simplifying options for admins.
…ing each call to add it.
…view/url changes for facility user management page changes.
Conflicts: kalite/main/views.py kalite/templates/current_users.html
As a first pass over the screenshots, the new navbar looks good. Does the landing page still need to be 'watch videos' or 'do exercises'? It seems like that would be better to redirect to something else, no? 'Help' seems like the wrong name for the tab that has additional functions over and above links to help documentation. Might be worth either splitting out the help docs from the rest of that admin panel, or changing the name. |
@rtibbles - thanks for the comments, appreciate it!
Sorry, it redirects to the "overview" page--I just tend to screen-shot the homepage :)
Right, that's the plan (to migrate things out, and add a user's manual). I've already moved the clock set to the "overview" panel (and will add to the "device summary" page as well, and plan to finish that as I go. |
@bcipolli This is amazing, I have been thinking about combining these nav item, they are pretty much exactly what I was imagined. I don't have to test the actual code, because I gonna drive back home later in 10 min, will check around the code 10pm here. The only potential issue i see here is "video" might be understood as "watch video", but I think it's fine in admin page. |
@wangguan59 Thanks, I'm glad it's looking good! I agree that "Video" should be OK for administrators. The code isn't quite ready for testing--I posted this to share the screen shots mostly, and get feedback on that. I will be working on this code tonight, and hope to have something for testing tomorrow morning (about 12 hours from now). |
@wangguan59 any time to move forward on this? The longer we wait, the more out of sync this gets. |
@bcipolli I will take a look, will respond you this afternoon |
So this has been severely broken by the latest refactor. I suggest we look at whether this can be merged in some form or another, with the existing user management page being used under the "user" tab, and other functions labeled as "NYI" |
…w_admin Conflicts: kalite/control_panel/views.py kalite/facility/decorators.py kalite/facility/views.py kalite/main/api_views.py kalite/main/urls.py kalite/main/views.py kalite/templates/admin_distributed.html kalite/templates/facility/current_users.html kalite/templates/facility/facility_admin.html kalite/templates/updates/update_videos.html kalite/updates/views.py
…auses exception instead of 404)
…to new_admin Conflicts: kalite/templates/base.html kalite/templates/control_panel/group_users_management.html kalite/templates/updates/update_videos.html kalite/updates/views.py
…in a (blocking) view
…w_admin Conflicts: kalite/securesync/engine/models.py kalite/templates/base.html kalite/templates/updates/update_videos.html kalite/updates/views.py
…w_admin Conflicts: kalite/distributed/views.py
@aronasorman I believe merging this now may be the best way to go.
So my suggestion is to merge to develop (which is a month away from release anyway), and iterate, rather than holding out, making no progress, and continually addressing merge conflicts. What say you sir? |
Sure, I have no problem merging as long as @wangguan59 is alright with the changes so far. |
Cool. @wangguan59 didn't like the current button setup, but otherwise was satisfied. Will merge, and those button things can be addressed in the code as well. Will open up separate issues for them once this is merged. |
…w_admin Conflicts: kalite/facility/decorators.py kalite/i18n/custom_context_processors.py kalite/templates/base.html
New administrative interface
Addresses at least: #193 #364 #974 #689
Sending this PR now, even though it's not done, so others will be aware of where I'm at, and where I'm heading.
In building documentation for administration of KA Lite, I realized that our admin interface doesn't have overall coherence.
I'm redesigning the admin interface with 4 basic actions in mind:
I believe from this interface, admins will have clear entry points into each function they will want to do, and the user's manual will be much more straightforward.
Here are a few screenshots of where I'm at so far!
![screen shot 2013-12-18 at 10 27 44 pm](https://camo.githubusercontent.com/4bd17f65888a7e04386d72236aaac7795b7f6a6ce1f006bfaa5fd5124a4f3a56/68747470733a2f2f662e636c6f75642e6769746875622e636f6d2f6173736574732f343037323435352f313738323039302f62353966353936302d363861332d313165332d386664342d3862616464386264383132632e706e67)
![screen shot 2013-12-19 at 2 00 31 pm](https://camo.githubusercontent.com/1ae4201aff089439160d39789664280cd2d1798639f964a582e65055a992e46d/68747470733a2f2f662e636c6f75642e6769746875622e636f6d2f6173736574732f343037323435352f313738323134352f36313031643161362d363861352d313165332d393036642d3164653938303863643633352e706e67)
![screen shot 2013-12-19 at 1 57 23 pm](https://camo.githubusercontent.com/071cbd92a82228d9263d94d96ef03c0e77a6e1f6627427dfcfecd009a3272163/68747470733a2f2f662e636c6f75642e6769746875622e636f6d2f6173736574732f343037323435352f313738323134372f36323562316535342d363861352d313165332d396334322d3261366661366261323232342e706e67)
![screen shot 2013-12-19 at 2 00 52 pm](https://camo.githubusercontent.com/a5cb82f060b6e29f155cde428414ddfd071a1b07de03a381c29e8d1ed9b2e163/68747470733a2f2f662e636c6f75642e6769746875622e636f6d2f6173736574732f343037323435352f313738323135302f36656230393739632d363861352d313165332d393165632d3637353965343138656366382e706e67)
![screen shot 2013-12-19 at 2 01 01 pm](https://camo.githubusercontent.com/3fd123daf13991609dc5883177f4f57a7c516d9960d3b4509de54b40bb9f99d6/68747470733a2f2f662e636c6f75642e6769746875622e636f6d2f6173736574732f343037323435352f313738323135312f37313437383661302d363861352d313165332d386130332d3634633931306130353966622e706e67)
![screen shot 2013-12-19 at 2 01 09 pm](https://camo.githubusercontent.com/0afb39774c6178cad8261c089935f77018489cd4d1e547a8b5ca0267036ff37f/68747470733a2f2f662e636c6f75642e6769746875622e636f6d2f6173736574732f343037323435352f313738323135322f37333737613138612d363861352d313165332d393538652d3737383163613336366365642e706e67)
All are welcomed to comment! @wangguan59 @rtibbles I know you've dealt with these things before, and hope you might have time for feedback in the next 16 hours--the timeline for rolling something out in Gitwe.