New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing [[ radio ]] placeholder in exercise questions with radio buttons #5172

Closed
benjaoming opened this Issue Jun 17, 2016 · 23 comments

Comments

Projects
None yet
4 participants
@benjaoming
Member

benjaoming commented Jun 17, 2016

Summary

@aronasorman wrote in #5131

I've tested a locally built content pack and most of the problem questions seem to be gone now! However, there still are a few questions that don't show answer areas. This time, they seem to be focused on True/False questions. Here's an example I found:

http://127.0.0.1:8008/learn/khan/humanities/us-history/road-to-revolution/declaration-of-independence/aspen-us-declaration-of-independence-quiz/

Branch or installer method

  • Branch: 0.16.x

Screenshots

screenshot from 2016-06-17 22 53 22

Real-life consequences (anything community should be aware, for instance how it affects your deployment)

We still don't know the count of affected questions.

@benjaoming benjaoming added this to the 0.16.7 milestone Jun 17, 2016

@benjaoming benjaoming changed the title from Problems in some True/False quesions to Problems in some True/False questions Jun 17, 2016

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Aug 1, 2016

Member

I'm afraid this issue is not seeing enough progress to be fixed in a 0.16 patch release, let's postpone it for 0.17.

The vast amount of exercises have already been fixed, so it's okay to relax and enjoy that, too :)

Member

benjaoming commented Aug 1, 2016

I'm afraid this issue is not seeing enough progress to be fixed in a 0.16 patch release, let's postpone it for 0.17.

The vast amount of exercises have already been fixed, so it's okay to relax and enjoy that, too :)

@benjaoming benjaoming modified the milestones: 0.17.0, 0.16.7 Aug 1, 2016

@benjaoming benjaoming modified the milestones: 0.17.0, 0.17.1 Mar 19, 2017

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Apr 7, 2017

Member

Same exercise, still reproducing

Member

benjaoming commented Apr 7, 2017

Same exercise, still reproducing

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Apr 7, 2017

Member

This question works:

screenshot from 2017-04-07 16-34-27

And this, mysteriously doesn't:

screenshot from 2017-04-07 16-34-59

Member

benjaoming commented Apr 7, 2017

This question works:

screenshot from 2017-04-07 16-34-27

And this, mysteriously doesn't:

screenshot from 2017-04-07 16-34-59

@benjaoming benjaoming modified the milestones: 0.18, 0.17.1 Apr 7, 2017

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene May 3, 2017

Member

Hi @benjaoming it seems like this issue is not just about True/False questions. I looked at the JSON data for each question that isn't generating properly. This is just a hunch, but maybe there was a problem while generating these JSON data. In addition, as far as I have observed, most question that don't generate/display correctly has an author_name ['James Lewis']

This question is a a multiple choice kind

pk: 7477
id: x5cea7a853e9aa640
screen shot 2017-05-03 at 5 43 12 pm

{"hints":[{"content":"In the 18th century, many Americans were influenced by the ideas of the Enlightenment. One movement that grew out of the Enlightenment was Deism. Deists did not ascribe to the specific beliefs of religious groups of their time and believed that while God had created the universe, He also did not interfere in human affairs. \n\n[See this video to review these ideas] /learn/khan/humanities/us-history/road-to-revolution/declaration-of-independence/life-liberty-and-the-pursuit-of-happiness/"}],"question":{"content":"Deists… ","widgets":{"radio 1":{"type":"radio","options":{"choices":[{"content":"pushed for the establishment of a state-supported church. ","correct":false},{"content":"believed in a Creator, but did not hold to a specific religious dogma. ","correct":true},{"content":"believed that the Declaration should not refer to a God of any sort.","correct":false},{"content":"were banned in the 13 colonies. ","correct":false}],"randomize":true}}}},"answerArea":{"type":"radio","options":{"choices":[{"content":"pushed for the establishment of a state-supported church. ","correct":false},{"content":"believed in a Creator, but did not hold to a specific religious dogma. ","correct":true},{"content":"believed that the Declaration should not refer to a God of any sort.","correct":false},{"content":"were banned in the 13 colonies. ","correct":false}],"randomize":true}}}

and it displays this

screen shot 2017-05-03 at 5 43 12 pm 2

Member

mrpau-eugene commented May 3, 2017

Hi @benjaoming it seems like this issue is not just about True/False questions. I looked at the JSON data for each question that isn't generating properly. This is just a hunch, but maybe there was a problem while generating these JSON data. In addition, as far as I have observed, most question that don't generate/display correctly has an author_name ['James Lewis']

This question is a a multiple choice kind

pk: 7477
id: x5cea7a853e9aa640
screen shot 2017-05-03 at 5 43 12 pm

{"hints":[{"content":"In the 18th century, many Americans were influenced by the ideas of the Enlightenment. One movement that grew out of the Enlightenment was Deism. Deists did not ascribe to the specific beliefs of religious groups of their time and believed that while God had created the universe, He also did not interfere in human affairs. \n\n[See this video to review these ideas] /learn/khan/humanities/us-history/road-to-revolution/declaration-of-independence/life-liberty-and-the-pursuit-of-happiness/"}],"question":{"content":"Deists… ","widgets":{"radio 1":{"type":"radio","options":{"choices":[{"content":"pushed for the establishment of a state-supported church. ","correct":false},{"content":"believed in a Creator, but did not hold to a specific religious dogma. ","correct":true},{"content":"believed that the Declaration should not refer to a God of any sort.","correct":false},{"content":"were banned in the 13 colonies. ","correct":false}],"randomize":true}}}},"answerArea":{"type":"radio","options":{"choices":[{"content":"pushed for the establishment of a state-supported church. ","correct":false},{"content":"believed in a Creator, but did not hold to a specific religious dogma. ","correct":true},{"content":"believed that the Declaration should not refer to a God of any sort.","correct":false},{"content":"were banned in the 13 colonies. ","correct":false}],"randomize":true}}}

and it displays this

screen shot 2017-05-03 at 5 43 12 pm 2

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene May 3, 2017

Member

Here is another one that isn't a True/False question.

pk: 20744
id: x699f189dd5bcc110

{"hints":[{"content":"The authors of the Declaration struck a balance in their justification of natural rights. Their explanations looked to both self-evident truths discerned by human reason and the fact that the Creator was the source of these rights. The authors refer to these rights as unalienable which means that no king or government could ever legitimately violate them. \n\n[Watch this video to review these ideas] /learn/khan/humanities/us-history/road-to-revolution/declaration-of-independence/life-liberty-and-the-pursuit-of-happiness/\n\n "}],"question":{"content":""endowed by their Creator with certain unalienable rights" \n\nThis above phrase reflects the authors of the Declaration's belief that\n\n","widgets":{"radio 1":{"type":"radio","options":{"choices":[{"content":"kings ought to have absolute power since they ruled by divine right.","correct":false},{"content":"all people enjoyed certain rights which could never legitimately be taken away from them. ","correct":true},{"content":"there should be no separation between church and state in their new country. ","correct":false},{"correct":false,"content":"that people should enjoy absolute freedom to do as they pleased in their new country. "}],"randomize":true}}}},"answerArea":{"type":"radio","options":{"choices":[{"correct":false,"content":"kings ought to have absolute power since they ruled by divine right."},{"content":"all people enjoyed certain rights which could never legitimately be taken away from them. ","correct":true},{"content":"there should be no separation between church and state in their new country. ","correct":false},{"content":"that people should enjoy absolute freedom to do as they pleased in their new country. ","correct":false}],"randomize":true}}}

screen shot 2017-05-03 at 5 50 40 pm 2

screen shot 2017-05-03 at 5 50 40 pm

Dropdown type of questions seem to generate fine.

screen shot 2017-05-03 at 5 53 50 pm 2

Member

mrpau-eugene commented May 3, 2017

Here is another one that isn't a True/False question.

pk: 20744
id: x699f189dd5bcc110

{"hints":[{"content":"The authors of the Declaration struck a balance in their justification of natural rights. Their explanations looked to both self-evident truths discerned by human reason and the fact that the Creator was the source of these rights. The authors refer to these rights as unalienable which means that no king or government could ever legitimately violate them. \n\n[Watch this video to review these ideas] /learn/khan/humanities/us-history/road-to-revolution/declaration-of-independence/life-liberty-and-the-pursuit-of-happiness/\n\n "}],"question":{"content":""endowed by their Creator with certain unalienable rights" \n\nThis above phrase reflects the authors of the Declaration's belief that\n\n","widgets":{"radio 1":{"type":"radio","options":{"choices":[{"content":"kings ought to have absolute power since they ruled by divine right.","correct":false},{"content":"all people enjoyed certain rights which could never legitimately be taken away from them. ","correct":true},{"content":"there should be no separation between church and state in their new country. ","correct":false},{"correct":false,"content":"that people should enjoy absolute freedom to do as they pleased in their new country. "}],"randomize":true}}}},"answerArea":{"type":"radio","options":{"choices":[{"correct":false,"content":"kings ought to have absolute power since they ruled by divine right."},{"content":"all people enjoyed certain rights which could never legitimately be taken away from them. ","correct":true},{"content":"there should be no separation between church and state in their new country. ","correct":false},{"content":"that people should enjoy absolute freedom to do as they pleased in their new country. ","correct":false}],"randomize":true}}}

screen shot 2017-05-03 at 5 50 40 pm 2

screen shot 2017-05-03 at 5 50 40 pm

Dropdown type of questions seem to generate fine.

screen shot 2017-05-03 at 5 53 50 pm 2

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming May 3, 2017

Member

@mrpau-eugene you can manipulate the exercise data directly in ~/.kalite/database/content_khan_en.sqlite to see if you can pinpoint the problem through the JSON data?

For the record (because I haven't made note of it anywhere else): This error doesn't seem to give a javascript exception or traceback.

Member

benjaoming commented May 3, 2017

@mrpau-eugene you can manipulate the exercise data directly in ~/.kalite/database/content_khan_en.sqlite to see if you can pinpoint the problem through the JSON data?

For the record (because I haven't made note of it anywhere else): This error doesn't seem to give a javascript exception or traceback.

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene May 3, 2017

Member

@benjaoming okay. will try to see if I the culprit is really in the JSON data

Member

mrpau-eugene commented May 3, 2017

@benjaoming okay. will try to see if I the culprit is really in the JSON data

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene May 4, 2017

Member

@benjaoming I think this piece of text that is highlighted is required for the questions to display correctly. After adding this line, it works fine 🤣

screen shot 2017-05-04 at 9 52 04 am

Working:

screen shot 2017-05-04 at 8 42 32 am

Member

mrpau-eugene commented May 4, 2017

@benjaoming I think this piece of text that is highlighted is required for the questions to display correctly. After adding this line, it works fine 🤣

screen shot 2017-05-04 at 9 52 04 am

Working:

screen shot 2017-05-04 at 8 42 32 am

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming May 4, 2017

Member

Great find @mrpau-eugene !

Let's ask @rtibbles what he thinks about the solution. Is this because of an error in upstream data, an old version of Perseus or should we try sanitizing these data in the ka-lite-content-packs?

Member

benjaoming commented May 4, 2017

Great find @mrpau-eugene !

Let's ask @rtibbles what he thinks about the solution. Is this because of an error in upstream data, an old version of Perseus or should we try sanitizing these data in the ka-lite-content-packs?

@benjaoming benjaoming changed the title from Problems in some True/False questions to Missing [[ radio ]] placeholder in exercise questions with radio buttons May 4, 2017

benjaoming added a commit that referenced this issue May 4, 2017

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles May 4, 2017

Member

It is the [[ radio 1]] that is vital to proper rendering, this is what indicates that the radio boxes should be present.

This looks like an upstream data issue, but you can double check by looking at the item data on Khan Academy at http://www.khanacademy.org/api/internal/assessment_items/

Member

rtibbles commented May 4, 2017

It is the [[ radio 1]] that is vital to proper rendering, this is what indicates that the radio boxes should be present.

This looks like an upstream data issue, but you can double check by looking at the item data on Khan Academy at http://www.khanacademy.org/api/internal/assessment_items/

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles
Member

rtibbles commented May 4, 2017

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles May 4, 2017

Member

Seems like the [[ radio 1]] is missing in the source data above too.

Member

rtibbles commented May 4, 2017

Seems like the [[ radio 1]] is missing in the source data above too.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming May 4, 2017

Member

@rtibbles is there advice for @mrpau-eugene about how to report the issue upstream? I guess we don't want to fix such issues in ka-lite-content-packs...

Member

benjaoming commented May 4, 2017

@rtibbles is there advice for @mrpau-eugene about how to report the issue upstream? I guess we don't want to fix such issues in ka-lite-content-packs...

@rtibbles

This comment has been minimized.

Show comment
Hide comment
@rtibbles

rtibbles May 4, 2017

Member

My guess would be that this might be flagged to not be shown on the main KA site, so if you can't see it there, it may be that we shouldn't be downloading it.

Member

rtibbles commented May 4, 2017

My guess would be that this might be flagged to not be shown on the main KA site, so if you can't see it there, it may be that we shouldn't be downloading it.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming May 4, 2017

Member

@mrpau-eugene worth investigating if we are including questions that should be skipped because they are flagged as @rtibbles suggests they might be.

In case they are flagged, we would have to check up on whether the ka-lite-content-packs is properly skipping these exercise questions and whether we have to build a new English content pack for that reason.

Member

benjaoming commented May 4, 2017

@mrpau-eugene worth investigating if we are including questions that should be skipped because they are flagged as @rtibbles suggests they might be.

In case they are flagged, we would have to check up on whether the ka-lite-content-packs is properly skipping these exercise questions and whether we have to build a new English content pack for that reason.

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene May 5, 2017

Member

@benjaoming @rtibbles
It seems like they aren't flagged as a question to be skipped in the main site as shown here:

screen shot 2017-05-05 at 8 45 29 am

I kinda don't understand but the placeholder has a value of 2 while other questions has a value of 1. Can someone explain to me what this value is for or what does it do? For a clarification.

[[☃ radio 2]]

screen shot 2017-05-05 at 8 48 41 am

Btw, here is the unicode of the snowman emoji. I found it somewhere in some questions \u2603.

Member

mrpau-eugene commented May 5, 2017

@benjaoming @rtibbles
It seems like they aren't flagged as a question to be skipped in the main site as shown here:

screen shot 2017-05-05 at 8 45 29 am

I kinda don't understand but the placeholder has a value of 2 while other questions has a value of 1. Can someone explain to me what this value is for or what does it do? For a clarification.

[[☃ radio 2]]

screen shot 2017-05-05 at 8 48 41 am

Btw, here is the unicode of the snowman emoji. I found it somewhere in some questions \u2603.

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming May 5, 2017

Member

@mrpau-eugene what's the diff between the KA.org JSON data for the above question, and the JSON data found in the KA Lite content database?

Member

benjaoming commented May 5, 2017

@mrpau-eugene what's the diff between the KA.org JSON data for the above question, and the JSON data found in the KA Lite content database?

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene May 5, 2017

Member

@benjaoming aside from the missing [[\u2603 radio 2]], JSON data coming from KhanAcademy:

The widgets contains this two objects
"wdigets": {"radio 1": {....}, "radio 2":{...}} while the contents from the KA Lite content database only has "widgets":{"radio 1": {...}}

also, the "answerArea" object coming from KhanAcademy website contains only contains these:
screen shot 2017-05-05 at 8 40 10 pm 1

while the contents in the KA Lite Database contains:
screen shot 2017-05-05 at 8 40 26 pm

Member

mrpau-eugene commented May 5, 2017

@benjaoming aside from the missing [[\u2603 radio 2]], JSON data coming from KhanAcademy:

The widgets contains this two objects
"wdigets": {"radio 1": {....}, "radio 2":{...}} while the contents from the KA Lite content database only has "widgets":{"radio 1": {...}}

also, the "answerArea" object coming from KhanAcademy website contains only contains these:
screen shot 2017-05-05 at 8 40 10 pm 1

while the contents in the KA Lite Database contains:
screen shot 2017-05-05 at 8 40 26 pm

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming May 5, 2017

Member

@mrpau-eduard I'm getting a feeling that it's worth seeing if this issue and the data in our content database can be made to match what's on KA.org by building a new English content pack en-zip, at least for further investigation. Perhaps ask @mrpau-eduard to build it so you can see if this will correct the issue somehow?

As you can see, it was reported on Jun 17, 2016 - so it has persisted several of our content packs.

Member

benjaoming commented May 5, 2017

@mrpau-eduard I'm getting a feeling that it's worth seeing if this issue and the data in our content database can be made to match what's on KA.org by building a new English content pack en-zip, at least for further investigation. Perhaps ask @mrpau-eduard to build it so you can see if this will correct the issue somehow?

As you can see, it was reported on Jun 17, 2016 - so it has persisted several of our content packs.

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene May 5, 2017

Member

@benjaoming okay thanks for the suggestion :) I'll do some more investigations, too. I'll also talk to @mrpau-eduard regarding about this.

Member

mrpau-eugene commented May 5, 2017

@benjaoming okay thanks for the suggestion :) I'll do some more investigations, too. I'll also talk to @mrpau-eduard regarding about this.

@mrpau-eugene

This comment has been minimized.

Show comment
Hide comment
@mrpau-eugene

mrpau-eugene Jul 27, 2017

Member

@benjaoming @mrpau-eduard I would just like to take note here that this question has been removed from Khan Academy and confirmed that it no longer exists in the newly built content packs.

Member

mrpau-eugene commented Jul 27, 2017

@benjaoming @mrpau-eduard I would just like to take note here that this question has been removed from Khan Academy and confirmed that it no longer exists in the newly built content packs.

benjaoming added a commit to benjaoming/ka-lite that referenced this issue Jul 27, 2017

benjaoming added a commit to benjaoming/ka-lite that referenced this issue Jul 27, 2017

@benjaoming

This comment has been minimized.

Show comment
Hide comment
@benjaoming

benjaoming Jul 27, 2017

Member

Nice find @mrpau-eugene ! I'm closing this now, just added a release note about.

Member

benjaoming commented Jul 27, 2017

Nice find @mrpau-eugene ! I'm closing this now, just added a release note about.

@benjaoming benjaoming closed this Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment