New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout Django sessions #2159
Timeout Django sessions #2159
Conversation
current_datetime = datetime.datetime.now() | ||
|
||
# Timeout if idle time period is exceeded. | ||
if request.session.has_key('last_activity') and \ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Looks good. Can you write a test for this? |
Don't understand the test failure above. Only happened after linting fix, and only in 2.6, not 2.7. |
I had Travis restart that specific job. It's passing now. |
Hi there - sorry to report the number of logins is still not be recorded correctly. In my test over the last few days I logged in and out as different types of users, very soon the login count stops despite continual activity - I seperated the activity, logging in the following day or a few hours later. I have always logged out cleanly (unless the auto logout gets me before, so that's working). The actual activity is recorded fine and you can see when the user last did things. I got a strange inkling but enough to prove it yet - does the count get jammed if a user logs in more than once in a day and once that happens its then stuck? I will start a test now for this and report back. |
Hi there, just checking on this issue - any progress or need my help? |
Did you have a chance to look if it was the potential issue you highlighted On Fri, Aug 8, 2014 at 1:08 PM, mikewray notifications@github.com wrote:
Richard |
Mmmm...I did not. I will try test. Easy to do if you change the date on device. Will report back. |
Ok so I tested:
3.Change the date again to the following and do the same, login stays as 1. So my theory fails. There are definitely users in the system have more than one login in the system but something is jamming up somewhere. I can't confirm once the login count stops it does not budge again but that may be the case. I dunno...something not right. Let me know how else I can help? |
Hi there, just checking on this - any progress or anything I can do to help? Tx! |
Hi @mikewray - I have just finished up some other work. Will look at this by the end of the week and report back. |
This is working as per findings on the #2000 issue. The "number of login" issue can be fixed by #2276. @aronasorman I think we can close this now. |
Fixes #2000
Summary of changes:
@aronasorman and @dylanjbarth, please take a look.