Simplify logging and docs, and command line instructions #3955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a source of process leaks anyways
…ace NAIVE_LOGGING
|
The changes look fine. I agree a proper logging mechanism is needed. I still think it should be disabled by default, unless we can show that the rate at which the logfile grows is super slow. I'm going to time it for a few minutes and see what happens. |
| open(SERVER_LOG, "w").truncate() | ||
| print("Going to daemon mode, logging to {0}".format(SERVER_LOG)) | ||
| kwargs['out_log'] = SERVER_LOG | ||
| kwargs['err_log'] = SERVER_LOG |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
MCGallaspy
added a commit
that referenced
this pull request
Jun 30, 2015
Simplify logging and docs, and command line instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final amendment to #3601
@MCGallaspy I replaced NAIVE_LOGGING with a default log file that's just truncated every time you run
kalite start. I think it matches the needs better on a production system.I don't mind that it's there by default, because you'd have to have an incredible uptime and usage to make a significant impact on file size. Everything else will memory leak and die before this is an issue, and restarting kalite always truncates the log file.
In case there's a failure, normal users can refer to the log. I could add more interesting features that kept latest lines from a previous log, but on the other hand, I feel like we need to get a proper logging mechanism and not spend more time on this :)