Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run coverage in parallel mode #5443

Closed

Conversation

benjaoming
Copy link
Contributor

Summary

Been wondering a bit why coverage isn't showing up properly for kalite.cli so trying out this, even though I think CodeCov already knows that it's receiving separate reports from both CircleCI instances...

@codecov-io
Copy link

codecov-io commented Apr 12, 2017

Codecov Report

Merging #5443 into 0.17.x will decrease coverage by 3.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.17.x    #5443      +/-   ##
==========================================
- Coverage   51.94%   48.02%   -3.92%     
==========================================
  Files         143      120      -23     
  Lines        7466     6599     -867     
==========================================
- Hits         3878     3169     -709     
+ Misses       3588     3430     -158
Impacted Files Coverage Δ
kalite/cli.py 28.94% <0%> (-0.1%) ⬇️
kalite/inline/api_urls.py 100% <0%> (ø) ⬆️
kalite/inline/narratives.py 100% <0%> (ø) ⬆️
kalite/updates/urls.py 100% <0%> (ø) ⬆️
kalite/distributed/forms.py 100% <0%> (ø) ⬆️
kalite/contentload/api_urls.py 100% <0%> (ø) ⬆️
kalite/coachreports/api_urls.py 100% <0%> (ø) ⬆️
kalite/control_panel/urls.py 100% <0%> (ø) ⬆️
kalite/distributed/features/steps/generic.py
kalite/coachreports/features/steps/coachreports.py
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062188a...b848fe4. Read the comment docs.

@benjaoming
Copy link
Contributor Author

Merging #5443 into 0.17.x will decrease coverage by 0.01%.

facepalm

@benjaoming
Copy link
Contributor Author

Merging #5443 into 0.17.x will decrease coverage by 3.98%.
The diff coverage is n/a.

facepalm

@benjaoming
Copy link
Contributor Author

Wat on earth

Merging #5443 into 0.17.x will decrease coverage by 4.55%.
The diff coverage is n/a.

@benjaoming
Copy link
Contributor Author

benjaoming commented Apr 13, 2017

I understand now that the decrease in coverage is because I started ignoring BDD test steps and features, which had pretty high 'coverage' (because they were the test code).

@benjaoming
Copy link
Contributor Author

I can see coverage of kalite.cli locally but not in the online CodeCov report. Closing this PR and opening a new one in order to figure out if CodeCov isn't doing what it's supposed to.

@benjaoming benjaoming closed this Apr 14, 2017
@benjaoming benjaoming removed the has PR label Apr 14, 2017
@benjaoming benjaoming deleted the coverage-parallel branch April 14, 2017 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants