Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KContentRenderer mixin to better support custom completion criteria #214

Closed
rtibbles opened this issue Apr 7, 2021 · 1 comment · Fixed by learningequality/kolibri#8037
Assignees
Labels
category: library Shared code library P0 - critical Priority: Release blocker or regression

Comments

@rtibbles
Copy link
Member

rtibbles commented Apr 7, 2021

  • Add timeSpent as an optional prop for the KContentRenderer mixin
  • Add duration as nullable prop. If prop is null, then renderer must define 'durationDefault' data item to set a default value.
  • Add reusable progress by time spent computed prop to KContentRenderer mixin
    • Simplifying audio and video progress tracking by just using clock time instead of media track time
    • Allowing for unified time based progress tracking for any content type, based on duration or durationDefault
  • Add prop that presents a Boolean for 'always use duration based progress tracking' - forceTimeBasedProgress - which reads from the contentnode options force_time_based_progress flag.
@rtibbles rtibbles changed the title Add timeSpent as an optional prop for the KContentRenderer mixin Update KContentRenderer mixin to better support custom completion criteria Apr 7, 2021
@rtibbles rtibbles added the P0 - critical Priority: Release blocker or regression label Apr 7, 2021
@nucleogenesis nucleogenesis added the category: library Shared code library label Apr 13, 2021
@rtibbles
Copy link
Member Author

Fixed in #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: library Shared code library P0 - critical Priority: Release blocker or regression
Projects
None yet
3 participants