Fixes incorrectly truncated channel titles in 'Channel/source' and 'Language' dropdowns #4288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
This pr fixes the incorrectly truncated channel titles in 'Channel/source' and 'Language' dropdowna in the 'Import from channels' page search filters by adding the
dir="auto"
attribute to the dropdowns to allow for automatic handling of the text directions.Manual verification steps performed
Screenshots (if applicable)
After:
![Screenshot 2023-09-21 at 23 00 00](https://private-user-images.githubusercontent.com/5203639/269744543-be2b1323-1453-4a0d-aa4d-47442481d2a3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYwODA0ODIsIm5iZiI6MTcyNjA4MDE4MiwicGF0aCI6Ii81MjAzNjM5LzI2OTc0NDU0My1iZTJiMTMyMy0xNDUzLTRhMGQtYWE0ZC00NzQ0MjQ4MWQyYTMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTFUMTg0MzAyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWFiMDQ4OGUxMzE5OTYwODVmZWU4N2Q3Zjc2YTA0MDU4YWVhZWVhZjFkMDM1M2ViODExYmFiMDdjYWRjNTEzMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.z5K2W4qMnNNNhKfNLEc0BsXkTEUYkxxNFU6KqMQ89JA)
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
python manage.py restore_channel <channelId> --download-url https://studio.learningequality.org/ --editor <userEmail>
References
Fixes #4286
Comments
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)