Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrectly truncated channel titles in 'Channel/source' and 'Language' dropdowns #4288

Conversation

akolson
Copy link
Member

@akolson akolson commented Sep 21, 2023

Summary

Description of the change(s) you made

This pr fixes the incorrectly truncated channel titles in 'Channel/source' and 'Language' dropdowna in the 'Import from channels' page search filters by adding the dir="auto" attribute to the dropdowns to allow for automatic handling of the text directions.

Manual verification steps performed

  1. Go to https://hotfixes.studio.learningequality.org/en/accounts/#/ and sign in
  2. Change the language to Arabic.
  3. Open a channel and select the 'Import from channels' option
  4. Perform a search and observe the channel titles and languages(the long texts) in the 'Channel/source' and 'Language' drop-downs respectively.

Screenshots (if applicable)

After:
Screenshot 2023-09-21 at 23 00 00

Screenshot 2023-09-21 at 23 00 23

Does this introduce any tech-debt items?


Reviewer guidance

How can a reviewer test these changes?

  1. Go to http://localhost:8080/en/accounts/#/ and sign in
  2. If you need more channels. you can use the command below;
  • python manage.py restore_channel <channelId> --download-url https://studio.learningequality.org/ --editor <userEmail>
  1. Change the language to Arabic.
  2. Open a channel and select the 'Import from channels' option
  3. Perform a search and observe the channel titles and languages(the long texts) in the 'Channel/source' and 'Language' drop-downs respectively.

References

Fixes #4286

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are what was discussed in standup. Approving and merging to hotfixes for final manual QA

@marcellamaki marcellamaki merged commit 32bd214 into learningequality:hotfixes Sep 22, 2023
9 checks passed
@radinamatic
Copy link
Member

Confirming the fix, looking much better 👏🏽 🎉

2023-09-22_17-28-06

Had to reach out to zooming text only at 300% to see it applied to the language drop-down 😅

2023-09-22_17-22-16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants