Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary use of the core Kolibri store in tests #11725

Closed
2 tasks
Tracked by #5488
rtibbles opened this issue Jan 12, 2024 · 9 comments · Fixed by #11852
Closed
2 tasks
Tracked by #5488

Remove unnecessary use of the core Kolibri store in tests #11725

rtibbles opened this issue Jan 12, 2024 · 9 comments · Fixed by #11852
Assignees
Labels
DEV: frontend help wanted Open source contributors welcome

Comments

@rtibbles
Copy link
Member

When custom theming was first introduced to Kolibri, the theming state was made reactive by adding it to the core Vuex state.

This necessitated many component oriented frontend tests to inject the store into their tests in order to have the Vuex state available and prevent errors.

Since this happened, the reactive theming state has been extracted from Vuex and now lives independently. Therefore, injecting the store into these component tests is no longer needed.

Acceptance Criteria

For a starting point, many of the affected spec files were originally edited in this commit: 69856a1 but there may be others, or those files may have moved since!

@vaibhav-rm
Copy link

Can I work on this?

@LianaHarris360
Copy link
Member

Hi @vaibhav-rm yes, I will assign you to this issue. Please reach out if you have any questions!

@adityagarg06
Copy link

Hi @vaibhav-rm I have almost solved this issue,if you don't mind can i raise a PR.

@vaibhav-rm
Copy link

Hi @vaibhav-rm I have almost solved this issue,if you don't mind can i raise a PR.

Sure

@MisRob
Copy link
Member

MisRob commented Jan 30, 2024

@adityagarg06 and @vaibhav-rm Thanks both. @adityagarg06 kindly request you ask for an assignment of an issue and wait to be assigned next time, especially when someone has been assigned previously. Please have a look at the contributing guidelines.

@adityagarg06 adityagarg06 removed their assignment Feb 1, 2024
@nick2432
Copy link
Contributor

nick2432 commented Feb 3, 2024

can i work on this?

@MisRob
Copy link
Member

MisRob commented Feb 5, 2024

It seems no one is working on it now, so I think it's good to go @nick2432. Thank you.

@nick2432
Copy link
Contributor

nick2432 commented Feb 9, 2024

Hey @rtibbles , I'm raising a PR. Am I on the correct path?

@rtibbles
Copy link
Member Author

rtibbles commented Feb 9, 2024

I will take a look, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend help wanted Open source contributors welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants