-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary use of the core Kolibri store in tests #11725
Comments
Can I work on this? |
Hi @vaibhav-rm yes, I will assign you to this issue. Please reach out if you have any questions! |
Hi @vaibhav-rm I have almost solved this issue,if you don't mind can i raise a PR. |
Sure |
@adityagarg06 and @vaibhav-rm Thanks both. @adityagarg06 kindly request you ask for an assignment of an issue and wait to be assigned next time, especially when someone has been assigned previously. Please have a look at the contributing guidelines. |
can i work on this? |
It seems no one is working on it now, so I think it's good to go @nick2432. Thank you. |
Hey @rtibbles , I'm raising a PR. Am I on the correct path? |
I will take a look, thanks! |
When custom theming was first introduced to Kolibri, the theming state was made reactive by adding it to the core Vuex state.
This necessitated many component oriented frontend tests to inject the store into their tests in order to have the Vuex state available and prevent errors.
Since this happened, the reactive theming state has been extracted from Vuex and now lives independently. Therefore, injecting the store into these component tests is no longer needed.
Acceptance Criteria
For a starting point, many of the affected spec files were originally edited in this commit: 69856a1 but there may be others, or those files may have moved since!
The text was updated successfully, but these errors were encountered: