Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display issues for login language switcher #12447

Closed
rtibbles opened this issue Jul 16, 2024 · 1 comment
Closed

Display issues for login language switcher #12447

rtibbles opened this issue Jul 16, 2024 · 1 comment
Assignees
Labels
P1 - important Priority: High impact on UX

Comments

@rtibbles
Copy link
Member

Observed behavior

Incorrect overflow observed:
Screenshot from 2024-07-15 17-40-50

Modal positioned incorrectly:
Screenshot from 2024-07-15 17-40-41

Expected behavior

Language switcher should not overflow onto second line, modal should not be causing unnecessary page scroll.

User-facing consequences

Odd experience on many people's first use of Kolibri

Steps to reproduce

Go to the login page on desktop.
See the languages overflowing.
Click change language, see the modal awkwardly positioned.

Context

There has been recent work to update the language switcher (mostly in the context of the setup wizard) that may have contributed to this, but it seems likely that there has been an unintended interaction with other changes in 0.17 as well.

Fixing this should also make sure not to cause regressions in the setup wizard language switching display.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX
Projects
None yet
Development

No branches or pull requests

2 participants