Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spellchecking in contenteditable #6

Closed
kizu opened this issue Dec 11, 2011 · 6 comments
Closed

Spellchecking in contenteditable #6

kizu opened this issue Dec 11, 2011 · 6 comments

Comments

@kizu
Copy link
Collaborator

kizu commented Dec 11, 2011

In the contenteditable blocks at least in webkits there is a spellchecking:

The Unknown SVG

I don't think, that you need the spellchecking in code, so you can add spellcheck="false" attribute to the <pre>.

Also, you can then add spellcheck="true" only to the .token.comment, so it would be available only for comments. For HTML there are no tokens to the text nodes, but if you'll add them, then you can also turn the spellchecking on for them.

@LeaVerou
Copy link
Owner

Which browser is that from? Can't reproduce it in Chrome.

@kizu
Copy link
Collaborator Author

kizu commented Dec 11, 2011

In Chrome and Safari, but it appears only while you're editing and is placed the cursor out from the word, but not written down anything else.

So, writing the asdasd (with a space at the end) would trigger it to be shown, bit when you left this token, like by pressing enter, the red dashes disappear and would appear if you'd put the cursor near the incorrect word.

@LeaVerou
Copy link
Owner

Applied the fix, although I'm not sure spellcheck="true" on comment tokens actually does something. I can’t get it to show even if it was to save my life.

@kizu
Copy link
Collaborator Author

kizu commented Dec 11, 2011

Well, it works for me now, so, thanks! :)

@LeaVerou
Copy link
Owner

Does it work on comment tokens too? (it should spellcheck in those)

@kizu
Copy link
Collaborator Author

kizu commented Dec 11, 2011

Yeah, it works, you can see it here: Comment node with spellchecking here

@kizu kizu closed this as completed Dec 11, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants