Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate dppx values? #186

Closed
zachleat opened this issue May 31, 2017 · 3 comments
Closed

Inaccurate dppx values? #186

zachleat opened this issue May 31, 2017 · 3 comments

Comments

@zachleat
Copy link

It seems unlikely that all of these dppx values would be 1?

image

Specifically, my own Google Pixel device has a dppx value of 2.63, according to https://mydevice.io/ This data lists the Google Pixel dppx value as 1 though.

Should these values be changed to Unknown or something?
@zachleat zachleat mentioned this issue May 31, 2017
Closed
@arkon
Copy link
Collaborator

arkon commented May 31, 2017

Yes, it's probably better to just show something like ? rather than defaulting to 1.

@LeaVerou
Copy link
Owner

Heh, back when this website was first made, defaulting to 1 made sense.

@arkon
Copy link
Collaborator

arkon commented Jun 11, 2017

Made it so it just shows ? if it's not explicitely set in #188.

@arkon arkon closed this as completed Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zachleat @LeaVerou @arkon