Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't we remove the committed vendor directory ? #2

Closed
dgsb opened this issue Aug 24, 2018 · 5 comments
Closed

Shouldn't we remove the committed vendor directory ? #2

dgsb opened this issue Aug 24, 2018 · 5 comments
Labels
question Further information is requested

Comments

@dgsb
Copy link
Contributor

dgsb commented Aug 24, 2018

No description provided.

@dgsb dgsb added the question Further information is requested label Aug 24, 2018
@nbarbey
Copy link
Member

nbarbey commented Aug 24, 2018

I do not think so. Balancing pros and cons and since this repository is not so big with not so many dependencies, I would rather stick to commit the vendor.

Ref: https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory

@dgsb
Copy link
Contributor Author

dgsb commented Aug 24, 2018

Is is going to be practical for library consumer ?

@dgsb
Copy link
Contributor Author

dgsb commented Aug 24, 2018

I've checked randomly a few go libraries and applications, committing the vendor is not something which is commonly done for library.

@Peltoche
Copy link
Contributor

Peltoche commented Feb 8, 2019

Hi!

I agree with @dgsb. It doesn't seems a common practice for open-source libraries.

@nbarbey
Copy link
Member

nbarbey commented Feb 8, 2019

Can you propose a PR for this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants