Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support Secrets Manager #54

Closed
jaketrent opened this issue Apr 4, 2018 · 2 comments
Closed

Feature request: support Secrets Manager #54

jaketrent opened this issue Apr 4, 2018 · 2 comments

Comments

@jaketrent
Copy link

I can't tell if you support this or not... can one use the Secrets Manager to store the Evolve.ConnectionString?

As in:
https://docs.microsoft.com/en-us/aspnet/core/security/app-secrets?tabs=visual-studio

That would be great if it did. Initial testing leads to believe this is not yet supported.

For instance, this command adds the secret:

dotnet user-secrets set ConnectionStrings:Evolve.ConnectionString "Host=localhost;Username=postgres;Password=postgres;Database=todo"

But when I run the app after removing Evolve.ConnectionString from evolve.json, I get "Value cannot be null" for "Parameter name: connectionString"

@gcelet
Copy link

gcelet commented Apr 6, 2018

I would love that feature too :)
I think right now it's not supported but i could be mistaken.
I manage to use Evolve and Secrets Manager if i put evolve configuration in appsettings.json directly and write some glue code to wire everything.
I made a quick gist to illustrate this idea here: https://gist.github.com/gcelet/ab12595ae5edfcddc3a092cc0f2cd006
Hope this help

Evolve is a great lib: thank for you work @lecaillon

@lecaillon
Copy link
Owner

lecaillon commented Feb 23, 2019

Hi,

Thanks for your feedback and sorry for my (very) late response :)

Since the version 2.0, Evolve ships in 3 parts:

  • Evolve
  • Evolve.MSBuild
  • Evolve.CLI

The use of configuration files like evolve.json is only supported in Evolve.MSBuild.
On Windows the Evolve.MSBuild package adds a task executed at build time, that under the wood, runs the Evolve.CLI (evolve.exe) with the correct arguments. Evolve is completly separated from your app.

Use secrets is tied to the Configuration api loaded from your app. Access a secret from another app (MSBuild in that case) would be very complicated if even possible.

So, I would say the only package that "supports" secrets is: Evolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants