Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs in ledger-complete-at-point date completion #422

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

bcc32
Copy link
Collaborator

@bcc32 bcc32 commented Apr 11, 2024

ledger-complete-at-point currently seems completely broken for date completion
(e.g., "19" completes to the 19th of the current month, or the previous month,
whichever date is in the past from today).

I added some regression tests that demonstrate the bugs, and then separate
commits to fix each bug. I plan to squash the test and fix commits together
when merging.

(@purcell, I spent some time fighting with the CI over some old calling
conventions for functions (func-arity, which didn't exist; and encode-time,
which doesn't support a single argument in Emacs < 27, but the multiple-argument
form is marked "obsolete" in Emacs 29). What's ledger-mode's policy on
supporting Emacs major versions, is there generally some guideline we follow as
to when we're okay with abandoning support for older versions?)

Fix #419.

@bcc32 bcc32 requested a review from purcell April 11, 2024 00:07
@bcc32 bcc32 force-pushed the fix-date-completion branch 2 times, most recently from 77399ba to 031be96 Compare April 16, 2024 04:18
@purcell
Copy link
Member

purcell commented Jul 8, 2024

What's ledger-mode's policy on
supporting Emacs major versions, is there generally some guideline we follow as
to when we're okay with abandoning support for older versions?

I don't think it would be controversial to only support the latest three major versions, ie. dropping support for Emacs <= 26. I don't know if anyone is likely to declare a policy around this though.

@bcc32 bcc32 merged commit 17983be into ledger:master Jul 9, 2024
12 checks passed
@bcc32 bcc32 deleted the fix-date-completion branch July 9, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong number of arguments calling ledger-complete-at-point on date
2 participants