Fix some bugs in ledger-complete-at-point date completion #422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ledger-complete-at-point currently seems completely broken for date completion
(e.g., "19" completes to the 19th of the current month, or the previous month,
whichever date is in the past from today).
I added some regression tests that demonstrate the bugs, and then separate
commits to fix each bug. I plan to squash the test and fix commits together
when merging.
(@purcell, I spent some time fighting with the CI over some old calling
conventions for functions (func-arity, which didn't exist; and encode-time,
which doesn't support a single argument in Emacs < 27, but the multiple-argument
form is marked "obsolete" in Emacs 29). What's ledger-mode's policy on
supporting Emacs major versions, is there generally some guideline we follow as
to when we're okay with abandoning support for older versions?)
Fix #419.