Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.8: "Copy to New" button missing on transaction in closed period #4840

Closed
ehuelsmann opened this issue Jul 30, 2020 · 1 comment
Closed

1.8: "Copy to New" button missing on transaction in closed period #4840

ehuelsmann opened this issue Jul 30, 2020 · 1 comment
Labels
type:regression Functionality that broke over the last release cycle (1.5.x -> 1.5.y or 1.5.x -> 1.6.0)
Milestone
1.8.3

Comments

@ehuelsmann
Copy link
Member

When a transaction is in a closed period, it has no buttons at all. However, minimally, it should at least have "Copy to New".
@ehuelsmann ehuelsmann added the type:regression Functionality that broke over the last release cycle (1.5.x -> 1.5.y or 1.5.x -> 1.6.0) label Jul 30, 2020
@ehuelsmann ehuelsmann added this to the 1.8.0 milestone Aug 23, 2020
@ehuelsmann ehuelsmann modified the milestones: 1.8.0, 1.8 Sep 4, 2020
@ehuelsmann ehuelsmann modified the milestones: 1.8, 1.8.3 Sep 13, 2020
@ehuelsmann
Copy link
Member Author

Looking more closely to the code, it seems that the case is that the buttons disappear on data-entry (unsaved transactions). But that also removes the update button which can be used to move the transaction date to a point after the closing period

ehuelsmann added a commit to ehuelsmann/LedgerSMB that referenced this issue Sep 17, 2020
@ehuelsmann
Fix ledgersmb#4840: Buttons missing on invoice in closed period
ffcee60
ehuelsmann added a commit that referenced this issue Sep 17, 2020
@ehuelsmann
Merge pull request #5069 from ehuelsmann/issue-4840
a28e790 
Fix #4840: Buttons missing on invoice in closed period
ehuelsmann added a commit that referenced this issue Sep 17, 2020
@ehuelsmann
Merge pull request #5070 from ehuelsmann/1.8-issue-4840
07fb09c 
Fix #4840: Buttons missing on invoice in closed period
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:regression Functionality that broke over the last release cycle (1.5.x -> 1.5.y or 1.5.x -> 1.6.0)
Projects
None yet
Milestone
1.8.3
Development

No branches or pull requests
1 participant
@ehuelsmann