Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 1076, email not showing when emailing quote or order #175

Merged
merged 7 commits into from
Aug 22, 2014

Conversation

einhverfr
Copy link
Member

No description provided.

@pongraczi
Copy link
Contributor

Test result of fix for 1073 on 1.3.41

I applied and tested this patch in 1.3.41
I found that, there are some problems with it:
First, the parameters of the function invoking should be form-> instead of shelf-> (it was NULL) and the parameter should be 17 instead of 14 (I got no results in sql query, even I have a contact with billing email and CC):
$sth->execute( $form->{eca_id}, 17) || $self->dberror( $query );

Anyway, I got still empty email input fields even now I can see correct sql queries and as I tested these queries in the DB, it listed email addresses.

What did I miss?

@einhverfr
Copy link
Member Author

I have tested this and it is working on my system. Now orders and invoices work the same but aging reports do not.

einhverfr added a commit that referenced this pull request Aug 22, 2014
Fixing 1076, email not showing when emailing quote or order
@einhverfr einhverfr merged commit c5fb18a into ledgersmb:1.3 Aug 22, 2014
ehuelsmann added a commit that referenced this pull request Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants