Remove undefined errors in logger #4606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When does that trigger? This should not happen. |
ehuelsmann
added a commit
to ehuelsmann/LedgerSMB
that referenced
this pull request
May 16, 2020
…code Note that the current implementation assumes the DynamicWorkflow middleware preceeds it in its call chain. However, for old code, this isn't the case. Instead, don't derive the name of the script from the call context, but from the parameters passed on initialization. The action name can be had from the request object. Fixes ledgersmb#4606
ehuelsmann
added a commit
to ehuelsmann/LedgerSMB
that referenced
this pull request
May 16, 2020
…code Note that the current implementation assumes the DynamicWorkflow middleware preceeds it in its call chain. However, for old code, this isn't the case. Instead, don't derive the name of the script from the call context, but from the parameters passed on initialization. The action name can be had from the request object. Fixes ledgersmb#4606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the logger won't output undefined errors if called before
script_nameoraction_nameis initialized.