This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
EIP-4844: Handle data gas in txpool #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
changed the title
| @@ -108,6 +108,7 @@ func ParseGetPooledTransactions66(payload []byte, pos int, hashbuf []byte) (requ | |||
|
|
|||
| // == Pooled transactions == | |||
|
|
|||
| // TODO(eip-4844) wrappedWithBlobs = true? | |||
There was a problem hiding this comment.
yes probably true? (looks like I missed that in my PR)
txpool/pool.go
Outdated
| } | ||
|
|
||
| if intrinsicGas <= availableGas { // check for potential underflow | ||
| } else { |
There was a problem hiding this comment.
style: since the above clause continues the else is unnecessary
roberto-bayardo
approved these changes
Jun 22, 2023
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Jun 23, 2023
calmbeing
pushed a commit
to calmbeing/bsc-erigon-lib
that referenced
this pull request
Jul 10, 2023
Reworked bits of PR ledgerwatch#850. Only stubs for transaction parsing.
calmbeing
pushed a commit
to calmbeing/bsc-erigon-lib
that referenced
this pull request
Jul 12, 2023
Reworked bits of PR ledgerwatch#850. Only stubs for transaction parsing.
AskAlexSharov
pushed a commit
that referenced
this pull request
Sep 6, 2023
Reworked bits of PR #850. Only stubs for transaction parsing.
AskAlexSharov
pushed a commit
to erigontech/erigon
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked bits of PR #850. Only stubs for transaction parsing.