This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
implement extensions for eip-4844 #850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roberto-bayardo
force-pushed
the
eip-4844
branch
2 times, most recently
from
8993711
to
f16379f
Compare
|
merge devel plz |
roberto-bayardo
force-pushed
the
eip-4844
branch
from
8ae3d6a
to
c5046cf
Compare
done, build all good now! |
roberto-bayardo
force-pushed
the
eip-4844
branch
from
9e28f16
to
2090fc9
Compare
yperbasis
reviewed
Jan 30, 2023
yperbasis
reviewed
Jan 30, 2023
go.mod
Outdated
| @@ -106,3 +109,5 @@ require ( | |||
| google.golang.org/genproto v0.0.0-20221118155620-16455021b5e6 // indirect | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/ledgerwatch/interfaces => github.com/roberto-bayardo/interfaces v0.0.0-20230125140013-a42dd5f11cb5 | |||
There was a problem hiding this comment.
Please create a PR against ledgerwatch/interfaces.
There was a problem hiding this comment.
roberto-bayardo
force-pushed
the
eip-4844
branch
from
f4fdd9c
to
2b1ed1f
Compare
| w.sigHashEnd = end | ||
| originalBegin := begin | ||
| var err error | ||
| w.chainID, err = readUint256(payload, begin) |
There was a problem hiding this comment.
i guess this is ssz and we can move this helper func to erigon-lib/ssz package
There was a problem hiding this comment.
Yes there's a lot of ssz stuff that should be migrated or made to use erigon-lib/ssz. I can look into this next week if someone hasn't started on it already.
roberto-bayardo
force-pushed
the
eip-4844
branch
2 times, most recently
from
61a95ea
to
c89467f
Compare
roberto-bayardo
force-pushed
the
eip-4844
branch
from
c89467f
to
af6d929
Compare
roberto-bayardo
force-pushed
the
eip-4844
branch
2 times, most recently
from
fda051f
to
6118d6e
Compare
roberto-bayardo
force-pushed
the
eip-4844
branch
from
6118d6e
to
2f886fc
Compare
roberto-bayardo
force-pushed
the
eip-4844
branch
from
5835fd5
to
b0e3786
Compare
|
Merged with upstream. Blob tx tests are currently failing since the blob tx format is out of date and doesn't pass current verification rules, but since we are converting to RLP probably not worth fixing? |
|
cc: @yperbasis |
roberto-bayardo
force-pushed
the
eip-4844
branch
2 times, most recently
from
dd9304d
to
71b58ee
Compare
roberto-bayardo
force-pushed
the
eip-4844
branch
from
71b58ee
to
1340b60
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
Reworked bits of PR #850. Only stubs for transaction parsing.
calmbeing
pushed a commit
to calmbeing/bsc-erigon-lib
that referenced
this pull request
Jul 10, 2023
Reworked bits of PR ledgerwatch#850. Only stubs for transaction parsing.
calmbeing
pushed a commit
to calmbeing/bsc-erigon-lib
that referenced
this pull request
Jul 12, 2023
Reworked bits of PR ledgerwatch#850. Only stubs for transaction parsing.
AskAlexSharov
pushed a commit
that referenced
this pull request
Sep 6, 2023
Reworked bits of PR #850. Only stubs for transaction parsing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.