Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc daemon: log request params on debug verbosity #1087

Merged
merged 6 commits into from
Sep 9, 2020
Merged

rpc daemon: log request params on debug verbosity #1087

merged 6 commits into from
Sep 9, 2020

Conversation

AskAlexSharov
Copy link
Collaborator

@AskAlexSharov AskAlexSharov commented Sep 9, 2020 •
edited
Loading

Requested by: #1043

  • Don't log responses because it can be up to Gb.
  • Used default logger with debug verbosity.
  • No concept of access.log

Screen Shot 2020-09-09 at 21 34 29

@AskAlexSharov AskAlexSharov changed the title rpc_daemon_access_log [to discuss] rpc daemon: access.log Sep 9, 2020
@AskAlexSharov AskAlexSharov mentioned this pull request Sep 9, 2020
Closed
@AlexeyAkhunov
Copy link
Contributor

Perhaps we do not need to log the responses or make it optional

@AskAlexSharov
Copy link
Collaborator Author

Oh, i didn’t write - to enable need provide ‘—accesslog’ flag

@AskAlexSharov
Copy link
Collaborator Author

AskAlexSharov commented Sep 9, 2020 •
edited
Loading

  • Removed response because it can be up to Gb.
  • Used default logger with debug verbosity.
  • Removed concept of accesslog

Screen Shot 2020-09-09 at 21 34 29

@AskAlexSharov AskAlexSharov changed the title [to discuss] rpc daemon: access.log rpc daemon: access.log Sep 9, 2020
@AskAlexSharov AskAlexSharov changed the title rpc daemon: access.log rpc daemon: log request params on debug verbosity Sep 9, 2020
@AlexeyAkhunov AlexeyAkhunov merged commit 84b52a5 into master Sep 9, 2020
@AlexeyAkhunov AlexeyAkhunov deleted the rpc_daemon_access_log branch September 29, 2020 15:08
battlmonstr pushed a commit that referenced this pull request Sep 14, 2023
@Giulio2002
Ranges in execution.proto (#1087)
bae527e
cffls pushed a commit to cffls/erigon that referenced this pull request Sep 3, 2024
@V-Staykov
fix sendall (erigontech#1087)
58a3672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AskAlexSharov @AlexeyAkhunov